Feat/block channels refactor - #13491
Closed
mstudio005 wants to merge 380 commits into
Closed
Conversation
Migrate to Coil 3
…ate_empty_state_view Migrate empty_state_view xml/view to Jetpack Compose
# Conflicts: # app/src/main/java/org/schabi/newpipe/ui/components/common/NoItemsMessage.kt # app/src/main/java/org/schabi/newpipe/ui/components/video/comment/CommentRepliesDialog.kt
Migrate build to version catalogs
Sort dependencies in `libs.versions.toml`
…pose Migrate about activity to Jetpack Compose
…-loading Fix image loading
…_migration Complete the debug screen migration to Compose
…tion Replace the previous string-based resolution/fps/etc. handling for VideoStreams by parsing the 'getResolution()'-string to a data class to improve maintainability. Video resolutions (e.g. "720p60") were previously compared and matched using regex-based string manipulation all over the place. This was fragile, required repeated parsing and made it difficult to extend the matching logic. It can handle all the strings like before: "720p", "720p60" Additionally this patch can also handle strings like: "720p60@123k", or "720p@2m" Main changes: - Introduce internal data class VideoQuality (resolution, fps, bitrate, formatRank). - Introduce internal VideoStreamWithQuality to associate streams with parsed quality. - Parse quality only once. - Replace resolution string sorting with a comparator based on resolution -> fps -> formatRank -> bitrate. - Rework stream selection to use a priority-based matching algorithm (format, resolution, fps, bitrate). - Prefer candidates with bitrate closest to the requested one when multiple streams match the same priority class.
…ality-representation-and-stream-selection_refactor Rework video quality representation and stream selection refactor Added unit tests for ListHelper
Merge dev into refactor
…s-crash Fix crash when loading offline comments in CommentRepliesSource
… task Signed-off-by: Aayush Gupta <aayushgupta219@gmail.com>
The about libraries gradle plugin does merge of duplicate by defaults. Signed-off-by: Aayush Gupta <aayushgupta219@gmail.com>
Checkstyle was already requiring JDK 21 and now about libraries need it too Use the kotlin extension method as it will also configure it for java code Ref: https://kotlinlang.org/docs/gradle-configure-project.html#gradle-java-toolchains-support Signed-off-by: Aayush Gupta <aayushgupta219@gmail.com>
Merge dev into refactor
* add error screen compasable * add error activity * create separate privacy policy dialog * move base activity * refactor error activity and tiny tweaks * add new compose activity and navdisplay * refactor app to utilize new compose activity * clean up arguments in the ErrorReportScreen * get rid of redundant colors * tackle review issues * rename getErrorActivityIntent
remove AboutActivity
fix app crash on loading comment section with no internet
This was a hand-written implementation of channel blocking from scratch, including Room storage, a settings screen, long-press block actions, undo support, and filtering across the app. I also used a little Claude Code during the process for support while keeping the implementation itself written and verified by hand.
mstudio005
force-pushed
the
feat/block-channels-refactor
branch
from
May 11, 2026 06:18
f4891b5 to
f35d5d7
Compare
Author
|
Closing this because in this pr I accidentally targeted the wrong branch and included upstream history. I will open a fresh clean PR targeting refactor. Edit: Opened #13492 |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
19 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the changes in your PR
Before/After Screenshots/Screen Record
Fixes the following issue(s)
Relies on the following changes
APK testing:
The APK can be found by going to the "Checks" tab below the title. On the
left pane, click on "CI", scroll down to "artifacts" and click "app" to
download the zip file which contains the debug APK of this PR.
Due diligence