Skip to content

fix(tabby-agent): sanitize newlines in user-agent header string #4459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MaxwellCalkin wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(tabby-agent): sanitize newlines in user-agent header string #4459

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion clients/tabby-agent/src/http/tabbyApiClient.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,10 @@ export class TabbyApiClient extends EventEmitter {
const tabbyPluginName = clientInfo?.tabbyPlugin?.name;
const tabbyPluginVersion = clientInfo?.tabbyPlugin?.version;
const tabbyPluginInfo = tabbyPluginName ? `${tabbyPluginName}/${tabbyPluginVersion}` : "";
return `${envInfo} ${tabbyAgentInfo} ${ideInfo} ${tabbyPluginInfo}`.trim();
const raw = `${envInfo} ${tabbyAgentInfo} ${ideInfo} ${tabbyPluginInfo}`.trim();
// Sanitize newlines from the user-agent string, as some editors (e.g. Emacs)
// include newlines in their version info which are invalid in HTTP headers.
return raw.replace(/[\r\n]+/g, " ").replace(/\s{2,}/g, " ");
}

private createTimeOutAbortSignal(): AbortSignal {
Expand Down