fix(agent): preserve malformed tool-call arguments - #2306
Open
primorLee wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
function.argumentsProblem
When SGLang recognizes a tool call but its arguments are malformed JSON, the parser currently replaces the argument text with a
{"_raw_arguments": ...}sentinel mapping.The OpenAI adapter then serializes that sentinel, so clients receive a different argument string from the one produced by the model. The Anthropic adapter emits the sentinel as a normal executable
tool_use.input, even though Anthropic requires an input object and the model output was not valid.For the model output:
current
mainreturns:This PR keeps two representations at the parsing boundary: the original wire text and the canonical mapping used for history rendering. OpenAI receives the former unchanged. Anthropic only exposes calls whose arguments are representable as an object; an invalid call becomes a normal non-tool response and the turn remains marked
ill_formed.Valid object-valued tool calls and XML fallback calls keep their existing behavior.
Validation
70 passed, 1 skippedpre-commit: case-conflict, private-key, large-file, Ruff, autoflake, isort, and Black hooks passedgit diff --checkpassedCloses #2299