feat: report evaluation wall time - #2291
Open
skirdey wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RolloutManager.evalperf/eval_timethrough the existing eval metrics pathMotivation
Rollout generation already reports
perf/rollout_time, but periodic evaluation has no corresponding duration. On long-running jobs this makes evaluation pauses indistinguishable from rollout, training, or weight-sync stalls.Test plan
python3 -m py_compile slime/ray/rollout.py tests/test_rollout_metrics.py_eval_metricscontract execution passedgit diff --checkThe full
tests/test_rollout_metrics.pyrequires the project CUDA/SGLang test environment and is left to upstream CI.