feat: bound Megatron checkpoint retention - #2290
Open
skirdey wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--save-retain-countfor long-running RL jobsMotivation
Long jobs currently retain every multi-gigabyte Megatron checkpoint unless an external supervisor deletes them. This can exhaust local disks even when the job only needs a small resumable history. The retention operation runs only after synchronous completion, or after
maybe_finalize_async_saveconfirms an asynchronous save.The option is disabled by default.
Test plan
PYTHONPATH=$PWD uv run --no-project --with pytest --with pyyaml --with omegaconf pytest -q tests/utils/test_checkpoint_retention.py tests/test_megatron_argument_validation.pypython3 -m py_compile slime/utils/checkpoint_retention.py slime/utils/arguments.py slime/backends/megatron_utils/actor.py tests/utils/test_checkpoint_retention.pygit diff --check