Repository navigation
feat: seed the https database on up - #50
Merged
Merged
Conversation
All three https compose files now run build-db with -if-empty on every `up`, and ignis depends on it with service_completed_successfully, as the http environment already does. A fresh volume is seeded before ignis and the proxy start, a populated one is left unchanged, and a failed seed makes `up` exit 1. The seed profile is removed, so `pull` fetches build-db without it. With both environments behaving the same, the getting-started guide describes seeding once instead of per environment, the deployment steps drop the separate seed command, and the pinning example uses 0.7.0, the first release whose build-db accepts -if-empty.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extends the seed-on-
upbehaviour from #49 toenvironment/https. A baredocker compose up -din any environment now leaves ignis ready to serve.Changes
All three https compose files (
docker-compose.yml,docker-compose.prod.yml,docker-compose.quickstart.yml) runbuild-dbwith-if-emptyon everyup, andignisdepends on it withservice_completed_successfully. Theseedprofile is removed.up -dservice "build-db" didn't complete successfully, ignis and proxy not startedA populated database is rebuilt with
<compose prefix> run --rm build-db -if-empty=false.docs/getting-started.mdnow describes seeding once for both environments, the deployment steps arepullthenup -d, and the pinning example uses0.7.0. The seeder dockerfile comment is updated to match.No new image is needed: the pulled files use
build-db0.7.0 or later, which already accepts-if-empty.Checks
docker-compose.quickstart.ymlrun end to end with the published 0.7.0 images under a separate project name:up -d --waitexited 0 on an empty volume, and/variants/DEand/calculateanswered through Caddy; a secondupskipped the seed; with a wrongDB_PASSWORDonbuild-db,upexited 1 andignisandproxystayed inCreated.docker-compose.ymlanddocker-compose.prod.ymlpassdocker compose config. Theirbuild-dbwiring is the same as the files exercised above and in feat: seed the http database on up #49.mkdocs build --strictpasses.