feat(api): surface construction-year band on GET /data/:code - #37
Merged
Conversation
The backend wants to pre-fill a default construction year for a building from the TABULA variant code city2tabula already assigns it, without asking the user to type one. Year1_Building and Year2_Building - the archetype's period band - already exist as populated integer columns for every country (ResolvePeriodByYear and ListPeriods already read them), but GET /api/v1/data/:code did not expose them. Add both to BuildingThematic. The existing struct-mapper matches DB columns to struct fields by json tag, so no repository, handler, SQL, or migration change is needed - the columns already exist and are already populated. They land at tabula_data.BasicParameters.BuildingAppearance.Year1_Building / Year2_Building, using the same 0/9999 open-ended sentinels as /api/v1/periods. Closes #35
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
…tion-year-on-data # Conflicts: # docs/api.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The backend wants to pre-fill a default construction year for a
building from the TABULA variant code city2tabula already assigns it,
without asking the user to type one.
Year1_BuildingandYear2_Building- the archetype's period band - already exist aspopulated integer columns for every country (
ResolvePeriodByYearandListPeriodsalready read them), butGET /api/v1/data/:codedid notexpose them.
Change
Adds both fields to
BuildingThematic. The existing struct-mappermatches DB columns to struct fields by json tag, so no repository,
handler, SQL, or migration change is needed - the columns already
exist and are already populated.
They land at
tabula_data.BasicParameters.BuildingAppearance.Year1_Building/Year2_Building, using the same 0/9999 open-ended sentinels as/api/v1/periods.Testing
go test ./...model and passes after adding the fields.
Closes #35