feat(cli): drop -reset-citydb, point users at -import-data - #140
Merged
Merged
Conversation
The already-exists guidance now offers -import-data before -reset-db, so new source files do not cost the extracted features.
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-create-dbagainst an existing database pointed users at-reset-db, which drops every extracted feature and hand correction. The guidance now offers-import-datafirst, which adds new 3D city data and skips files already imported.-reset-citydbis removed along withResetCityDBOnly: it dropped and re-imported the CityDB schemas while leaving city2tabula features that referenced them in place.Flag help text and the README flag table match the current CLI.
Verified
go build ./...,go vet ./...pass.go test -count=1 ./internal/flags/... ./internal/db/...pass, including a new test asserting the already-exists guidance names-import-databeforereset-db.integrationtag) not run.