Repository navigation
fix: BuEM thermal class mapping, MILP wording, c_m unit - #119
Merged
Merged
Conversation
The editor offers five mass classes (VeryLight to VeryHeavy) but BuEM has three. The serialiser mapped only Medium and Heavy and sent every other value as light, so a VeryHeavy building reached BuEM as light. The five classes now map to light, light, medium, heavy and heavy. A class with no mapping throws with its name instead of falling back to light. c_m is sent beside the class as before, so the very-light and very-heavy capacities still reach BuEM; on reopen they read back as Light and Heavy.
The toggle's label and help text described MILP as optimising a
dispatch schedule against a rule-based heuristic. In BuEM, use_milp
chooses how the thermal model is solved: a mixed-integer linear
programme instead of the default sparse solver, slower but exact on
inequality constraints. The label, help text, section summary and the
building CSV's calculation_method now say that ("MILP" or "sparse").
The export labelled thermal_capacity as Wh/m2K, but the value is the editor's c_m, which is held and sent to BuEM in kJ/(m2K).
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three fixes to what the configurator sends to and says about BuEM.
What changes
a895442): the editor offers five mass classes, BuEM has three.VeryHeavywas sent aslight. The classes now map VeryLight/Light tolight, Medium tomedium, Heavy/VeryHeavy toheavy; an unmapped class throws with its name.c_mis still sent beside it, so the very-light and very-heavy capacities reach BuEM; on reopen they read back as Light and Heavy.c641c7e): it described dispatch optimisation against a rule-based heuristic.use_milpchooses BuEM's thermal solver (MILP instead of the default sparse solver). Label, help text, section summary and the CSVcalculation_methodnow say MILP or sparse.552d71d):thermal_capacitywas labelledWh/m2K; the value isc_minkJ/(m2K).Tests
buemAdapter.thermal.test.ts(new) and two cases inmodelExport.test.tsfail before and pass after.npm test96/96,npm run typecheckclean,npm run build:libsucceeds.