Feature/cooling electricity ground truth fixes

[jravani]

No description provided.

[jravani]

@copilot resolve the merge conflicts in this pull request

[Copilot]

Pull request overview

This PR improves how annual energy totals (heating/electricity/cooling) are sourced and presented in the Building Configurator by introducing explicit “source” metadata (BuEM vs. ignis estimate vs. user-uploaded ground truth), fixing BuEM cooling sign handling, and plumbing uploaded load profiles through to override headline totals.

Changes:

• Add “ground truth” flow for uploaded load profiles and use it as the highest-priority source for displayed annual totals.
• Correct BuEM cooling timeseries sign and enable cooling computation by default in the BuEM request payload.
• Update overview UI to label totals with their source and show a plain-language comparison note instead of the old heating-only delta badge.

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
src/app/lib/loadProfile.ts	Adds EnergySource/expanded EnergyTotals metadata and introduces pickUpdatedRows to identify newly uploaded series.
src/app/lib/buemApi.ts	Flips BuEM cooling timeseries sign so downstream consumers see positive cooling demand.
src/app/lib/buemAdapter.ts	Enables compute_cooling by default and preserves it on import.
src/app/components/BuildingConfigurator/shared/ui.tsx	Replaces heating-only delta badge with SourceTag and EnergyComparisonNote.
src/app/components/BuildingConfigurator/overview/useLoadProfileState.ts	Emits uploaded rows as “ground truth” via onGroundTruthChange.
src/app/components/BuildingConfigurator/overview/LoadProfileViewer.tsx	Exposes upload/download in more modes, relabels “hotwater” as cooling, and adds a combined-series average reference line.
src/app/components/BuildingConfigurator/overview/EnergyEnvelopeColumn.tsx	Plumbs onGroundTruthChange through to the viewer.
src/app/components/BuildingConfigurator/overview/BuildingSnapshotAside.tsx	Displays per-row source tags and comparison notes for heating/electricity/cooling.
src/app/components/BuildingConfigurator/BuildingConfigurator.tsx	Adds ground-truth + “confirmed heating” state and centralizes total-resolution logic in resolveDisplayEnergyTotals.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

@copilot resolve the merge conflicts in this pull request

Resolved and pushed. Merge conflicts are now addressed in commit 7c9c28a (with branch sync in 9174fc5).

[Copilot]

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated no new comments.

Suppressed comments (2)

src/app/components/BuildingConfigurator/shared/ui.tsx:99

• SourceTag re-declares the energy source union type instead of reusing the shared EnergySource type from lib/loadProfile. Keeping a single source of truth prevents accidental drift if the union changes.

export function SourceTag({ source }: { source?: 'ignis' | 'buem' | 'user' }) {

src/app/lib/buemApi.ts:145

• Cooling is still being mapped into the LoadDataPoint.hotwater field. Now that the UI and exports treat this series as "Cooling", keeping the underlying property named "hotwater" is misleading and makes future work (e.g. adding real DHW) error-prone.

        // LoadDataPoint has no cooling field. Reusing "hotwater" for BuEM's
        // cooling output matches the existing thermalSummary-based fallback
        // in BuildingConfigurator.tsx's computeEnergyTotals — not a
        // physically accurate label, but the established convention.
        // BuEM reports cooling as negative (its solver shares one signed
        // Q_HC axis: positive = heat added, negative = heat removed) — flip
        // it here so every downstream reader (chart, CSV export, totals)
        // sees a plain positive "energy needed for cooling" figure.
        hotwater: -(ts.cooling?.[i] ?? 0),

[Copilot]

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated no new comments.

Suppressed comments (5)

src/app/components/BuildingConfigurator/BuildingConfigurator.tsx:1330

• This icon-only close button (×) has no accessible name. Add an aria-label so screen readers can announce what it does.

                      <button
                        type="button"
                        onClick={() => setPvInvalidated(false)}
                        className="shrink-0 cursor-pointer text-sm leading-none text-amber-600"
                      >×</button>

src/app/lib/buemApi.ts:145

• Cooling timeseries values are flipped to positive, but thermalSummary.coolingKwh is still taken directly from the API response. If BuEM cooling totals share the same signed convention as the timeseries (as noted above), the summary will remain negative and disagree with chart/totals when the UI falls back to thermalSummary.

        // BuEM reports cooling as negative (its solver shares one signed
        // Q_HC axis: positive = heat added, negative = heat removed) — flip
        // it here so every downstream reader (chart, CSV export, totals)
        // sees a plain positive "energy needed for cooling" figure.
        hotwater: -(ts.cooling?.[i] ?? 0),

src/app/components/BuildingConfigurator/shared/ui.tsx:99

• SourceTag duplicates the EnergySource union instead of reusing the central type from lib/loadProfile.ts, which risks drift if sources change (and makes refactors harder).

export function SourceTag({ source }: { source?: 'ignis' | 'buem' | 'user' }) {

src/app/components/BuildingConfigurator/BuildingConfigurator.tsx:1316

• This icon-only close button (×) has no accessible name. Add an aria-label so screen readers can announce what it does.

This issue also appears on line 1326 of the same file.

                      <button
                        type="button"
                        onClick={() => setUploadError(null)}
                        className="shrink-0 cursor-pointer text-sm leading-none text-destructive"
                      >×</button>

src/app/components/BuildingConfigurator/BuildingConfigurator.tsx:288

• HeaderBtn renders an icon-only and relies on the title attribute for labeling. title isn't a reliable accessible name for screen readers; add aria-label (ideally matching tooltip).

      onClick={onClick}
      title={tooltip}
      className="size-7 flex items-center justify-center rounded-md cursor-pointer text-muted-foreground hover:bg-muted transition-colors duration-100 shrink-0 [&_svg]:size-4"