Skip to content

Uploaded load profile should be ground truth, not just chart data; move source tag to label; units missing /year #107

Closed

Description

@jravani

Problems

  1. The "live estimate" tag sat next to the value, not the label — and only ever said "live estimate" (ignis), with no equivalent for an uploaded profile.
  2. Uploading a load profile via the chart's Upload button only affected the chart itself — it never fed back into the "Annual energy demand" totals shown in the sidebar. If a user has real measured/simulated data, it should be treated as ground truth: it becomes the headline number for all three energy types, and both ignis's live estimate and BuEM's confirmed result should be shown as comparisons against it instead of the other way around.
  3. All three annual totals showed a bare "kWh" unit; should read "kWh/year" since these are annual figures.

Fix

  • shared/ui.tsx: generalize LiveEstimateTag/HeatingComparisonNote into SourceTag (rendered next to the label; says "estimated" for ignis, "user defined" for an uploaded profile, nothing for a confirmed BuEM run) and EnergyComparisonNote (generic reference-label comparison sentence, no longer heating-only).
  • loadProfile.ts: generalize EnergyTotals to carry a source/comparison per energy type (not just heating); add pickUpdatedRows() to identify which resolution an upload actually populated (previously a naive "pick the finest non-empty resolution" would wrongly grab the model's pre-existing hourly data instead of the just-uploaded file).
  • useLoadProfileState.ts / LoadProfileViewer.tsx / EnergyEnvelopeColumn.tsx: thread an onGroundTruthChange callback up from the file-upload handler to the parent.
  • BuildingConfigurator.tsx: resolveDisplayEnergyTotals() — when a ground-truth profile exists, it becomes the headline for all three totals; whichever model figure is currently "live" (ignis's estimate, or BuEM's confirmed result) is shown as the comparison, with a dynamic label ("ignis's live estimate" vs "the last full simulation").
  • Change the annual totals unit from "kWh" to "kWh/year".

Activity

  1. added a commit that references this issue on Aug 3, 2026
    63dca15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions