fix(assertions): a report quotes the statement as it was written - #14
Merged
Merged
Conversation
An import renames the predicates it brings in, inside @Assert statements too, and the report showed the renamed text: `DeliveredOrder o c a` came back as `Deliveredorder_DeliveredOrder o c a`. The statement is now kept as written for reports; the renamed one is only what gets translated. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
An import renames the predicates it brings in, inside
@Assertstatements too, and the report showed the renamed text. Withimport concepts.DeliveredOrder.DeliveredOrder;:Fix
The statement is kept as written for reports (
statement_source, stored when an import first renames it); the renamed text is only what gets translated to SQL.verify,runandassertions()now printDeliveredOrder o c a.Tests
tests/cli/test_assertions.py: an assertion naming an imported predicate reports its statement verbatim, and still translates.tests/cli: 545 passed, 33 skipped.cargo test --lib: 828 passed.Targets
feat/v2-assertions(#13), which it is based on.🤖 Generated with Claude Code