Add the deprecation-handling Sass options#99
Open
Amoifr wants to merge 1 commit into
Open
Conversation
This was referenced Jul 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #89.
@stof spotted that the supported Sass options were missing the deprecation-related ones, and suspected #67 (repeated options) would need solving first. Good news: that part is already done — #37 taught
SassBuilderto expand array values into repeated flags, whichload_pathalready relies on. So this is just wiring up what's missing:verbose--verbosefatal_deprecation--fatal-deprecationfuture_deprecation--future-deprecationsilence_deprecation--silence-deprecationOne caveat worth flagging:
--silence-deprecationonly exists since Dart Sass 1.74.0, while the binary this bundle downloads is pinned to 1.69.7. The other three work fine on the pinned binary (--future-deprecationworks there even thoughsass --helpdoesn't advertise it — verified 🕵️). Every option defaults tonulland is only emitted when set, so nothing changes for existing users; the docs note the version requirement.Tests cover both the CLI flag expansion and a functional build: opting into the
importdeprecation early warns, and marking it fatal turns it into a build error. I also fixed the$sassOptionsdocblocks, which still claimedbool|stringwhileload_pathhas been passing arrays since #37.Thanks for the bundle! 🙏