feat: Swapr V3 MVP - #1
Draft
ElRodrigote wants to merge 10 commits into
Draft
Conversation
ElRodrigote
marked this pull request as draft
February 18, 2025 12:02
Diogomartf
reviewed
Feb 18, 2025
Comment on lines
+51
to
+55
| metadata: { | ||
| name: "Algebra Integral", | ||
| description: "DEX Engine", | ||
| url: "https://integral.algebra.finance", | ||
| icons: [""], |
Diogomartf
reviewed
Feb 18, 2025
Comment on lines
+6
to
+9
| const BA_LIST = | ||
| "https://raw.githubusercontent.com/The-Blockchain-Association/sec-notice-list/master/ba-sec-list.json"; | ||
| const HONEYSWAP_LIST = "https://tokens.honeyswap.org/"; | ||
| // only load blocked list if on app url |
There was a problem hiding this comment.
Probably the are more tokenlists we can add (check stackly and swapr)
ElRodrigote
changed the base branch from
master
to
feat/swapr-v3-mvp-prettify
February 24, 2025 10:17
ElRodrigote
force-pushed
the
feat/swapr-v3-mvp-prettify
branch
from
February 24, 2025 10:43
79f60e4 to
fe2fe19
Compare
…ative variables, apply them where needed
ElRodrigote
force-pushed
the
feat/swapr-v3-mvp
branch
from
February 24, 2025 12:15
1b96eea to
ef9788c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is not working?
When I try to do swaps or create positions I get a ContractFunctionExecutionError: RPC Request failed. error (the error is pretty lengthy), it's an inner error from walletconnect, and I think it's because of the token lists Integral repo has, but I'm not sure, been struggling with this one for a while now. I was getting other set of errors that I managed to get past through but got stuck with this one
is the site running locally? what commands do we need to run?
These are the commands (you'll need an .env file, pasting it bellow)
any resources or docs you are following or are useful to have context?
I'm checking The Graph docs and Walletconnect docs mostly
can you show some previews of the UI (some screenshots)
what do you expect for a review on this PR? As it's a fork and we don't have much context, which makes it hard to give proper feedback, it will be easier when it's working with previews.
I've managed to get most of the APIs and URLs in place, so we can correctly get balances, ENS and chain data. With the swapbox and the pools, it seems we're getting that data from the generated files when we run the codegen command, that takes a few The Graph schemas from the codegen structure to generate the queries to get the token lists from. When I try to update those schemas to use the ones we have in Swapr Algebra UI, the command fails. Another alternative I'm thinking is to manually fetch all the lists (if I'm able) from URLs as we do in Stackly and try to consume those lists