Skip to content

Anze 5915 federated spe define implement the orchestrator tre agent task api with file based dataset access - #194

Closed
RitaPeixoto wants to merge 13 commits into
SwanseaUniversityMedical:mainfrom
promptlylabs:ANZE-5915-federated-spe-define-implement-the-orchestrator-tre-agent-task-api-with-file-based-dataset-access
Closed

RitaPeixoto wants to merge 13 commits into
SwanseaUniversityMedical:mainfrom
promptlylabs:ANZE-5915-federated-spe-define-implement-the-orchestrator-tre-agent-task-api-with-file-based-dataset-access

Conversation

@RitaPeixoto

Copy link
Copy Markdown

No description provided.

- Manage S3 users via the Ceph RGW Admin Ops API (/admin/user,
  /admin/metadata/user), AWS4-signed; drop the mc CLI helpers and
  AttachPolicyToUserAsync.
- Replace canned policy + attach with Principal-scoped statements merged
  into each bucket policy, tagged by policy-name Sids so they can be
  stripped on revoke. CreateProjectS3AccessPolicyAsync now takes the
  access key; RemovePolicyAsync takes the submission/output buckets.
- Create the user before granting access, and delete it if the grant fails.
- Pass vaultPath to DeleteCredentialHandlerBase.DeleteUserAsync so
  DeleteS3UserHandler can read the buckets back from Vault;
  CreateS3SecretHandler now stores them.
- CreateBucketPolicy is a no-op; BucketPolicySetPublic delegates to
  SetPublicPolicy.
- Point S3BucketPath at the Ceph Dashboard bucket view; RustFS comments
  updated to Ceph.

Not changed: ControllerHelpers.AddUserToMinioBucket (Keycloak claim ->
canned policy) has no Ceph equivalent and needs STS
AssumeRoleWithWebIdentity + IAM roles.
Add FederatedTaskSettings (DatasetBucket, DatasetPrefix) to Agent.Api and
create the dataset bucket at startup via IMinioTreHelper. Datasets are
CSVs under {DatasetPrefix}{name}/ in that bucket. The bucket is separate
from project buckets, so expired-project cleanup never deletes it.
Startup logs an error rather than failing if storage is unreachable.
This reverts commit 20c09ad. The TRE storage stays on RustFS, whose
console provides the Keycloak-backed upload UI that Ceph RGW lacks.
@RitaPeixoto
RitaPeixoto deleted the ANZE-5915-federated-spe-define-implement-the-orchestrator-tre-agent-task-api-with-file-based-dataset-access branch October 29, 2026 12:25
@RitaPeixoto
RitaPeixoto restored the ANZE-5915-federated-spe-define-implement-the-orchestrator-tre-agent-task-api-with-file-based-dataset-access branch October 29, 2026 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant