fix(raycast): guard registry microtask teardown by JustYannicc · Pull Request #598 · SuperCmdLabs/SuperCmd

JustYannicc · 2026-07-04T21:55:25Z

What changed

Added mounted lifecycle guards around queueMicrotask-scheduled registry updates for collected actions, list items, grid items, and MenuBarExtra registrations.
Cleared per-component registry/cache refs on teardown and ignored late registry API calls after unmount so stale registration closures are not retained by dead registries.
Added a focused Node harness for registry microtask lifecycle behavior across actions, list, grid, and menubar surfaces.

Why

Registry updates were coalesced through queueMicrotask, but an already-scheduled microtask could outlive the owning React component and call setState after unmount. The guards preserve the existing batching, ordering, payload semantics, and dirty-check behavior while suppressing post-unmount updates.

Compatibility impact

No public Raycast API behavior changes are intended. Mounted registry semantics, action/list/grid/menu payload shapes, ordering, batching, and existing dirty-check decisions are unchanged.

How tested

node --test scripts/test-registry-microtask-lifecycle.mjs
node --test scripts/test-registry-dirty-checks.mjs
node /opt/homebrew/lib/node_modules/npm/bin/npm-cli.js run typecheck:renderer
Codex LSP diagnostics on the four touched runtime files: no diagnostics found

Performance evidence

Lifecycle harness legacy reproduction: actions/list/grid/menubar each queued 1 pending callback and produced 1 post-unmount setState call.
Lifecycle harness fixed behavior: actions/list/grid/menubar each produced 0 setState calls and 0 post-unmount setState calls after unmount.
Dirty-check harness preserved no full-registry walks on optimized paths. Example 5000-item run: list single recreated equivalent before 5000 fullSnapshotItemWalks vs after 0 fullSnapshotItemWalks and 1 itemSignatureBuild; grid single recreated equivalent before 5000 fullSnapshotItemWalks vs after 0 fullSnapshotItemWalks and 1 itemSignatureBuild.

Stack validation

Started from codex/perf-wave3-integration-stack-20260704 at 206eab8. Pushed implementation branch codex/perf-wave4-registry-microtask-lifecycle from commit 17fb535.

Replaces

Raycast runtime registry microtask lifecycle cleanup child implementation for SuperCmd perf wave 4.

…perf-wave2-integration-stack-20260704 # Conflicts: # src/renderer/src/raycast-api/list-runtime-renderers.tsx # src/renderer/src/raycast-api/list-runtime.tsx

…perf-wave2-integration-stack-20260704 # Conflicts: # src/renderer/src/CameraExtension.tsx

…perf-wave2-integration-stack-20260704

…perf-wave2-integration-stack-20260704 # Conflicts: # src/renderer/src/raycast-api/list-runtime.tsx

…perf-wave2-integration-stack-20260704 # Conflicts: # scripts/bench-script-command-discovery.mjs # scripts/benchmark-file-search-delete-batch.mjs # scripts/lib/script-command-runner-harness.mjs # scripts/lib/ts-import.mjs # scripts/test-file-search-delete-batch.mjs # scripts/test-script-command-runner.mjs # src/main/file-search-index.ts # src/main/main.ts

…perf-wave2-integration-stack-20260704 # Conflicts: # scripts/lib/script-command-runner-harness.mjs # scripts/lib/ts-import.mjs # scripts/test-extension-lifecycle-sandbox.mjs # scripts/test-script-command-runner.mjs # src/main/main.ts # src/renderer/src/ExtensionView.tsx

…perf-wave2-integration-stack-20260704 # Conflicts: # .github/workflows/project-checks.yml # scripts/test-root-search-perf.mjs # src/renderer/src/CameraExtension.tsx # src/renderer/src/raycast-api/list-runtime.tsx

…-integration-stack-20260704

…e3-integration-stack-20260704

…erf-wave3-integration-stack-20260704 # Conflicts: # package.json # scripts/measure-extension-bundle-cache.mjs # scripts/test-icon-runtime-file-icon-cache.mjs # src/main/extension-runner.ts # src/renderer/src/components/HiddenExtensionRunners.tsx # src/renderer/src/raycast-api/icon-runtime-render.tsx

…/perf-wave3-integration-stack-20260704 # Conflicts: # scripts/test-browser-search-performance.mjs # scripts/test-root-search-perf.mjs

JustYannicc · 2026-07-05T00:36:05Z

Superseded by the clean consolidated wave4 renderer/Raycast PR: #599. That branch contains this PR's covered change on current main without the inherited broad-stack noise.

JustYannicc added 30 commits July 3, 2026 22:19

Batch AI chat stream updates

5ae51b3

Batch cursor prompt stream updates

18481a2

perf(ai): batch Raycast useAI streaming

be66d99

ci: add project regression checks

a1d8c7b

Add bundled TS import helper for tests

a1225c6

fix(types): make renderer typecheck clean

0799e71

ci(claude): fix review action on fork PRs

835bf3a

fix(i18n): restore Italian parity checks

4605c88

fix(pnpm): approve native build scripts

d4c6a9f

perf: cache local icon asset existence checks

986c87a

Virtualize emoji grid list rendering

9e4eed3

Memoize Phosphor icon resolution

5245253

Cache emoji caret session state

cfe2ec3

Stabilize list item registry order

83d6b0b

perf(launcher): window command list rendering

e03ad3e

perf(grid): virtualize grid rendering

f07b554

perf(settings): coalesce AI status polling

6f06eb4

perf(icons): coalesce file icon IPC

949a6fd

Remove root search ranking diagnostics

8ca7ec9

perf: optimize file search delete batches

fb857f2

perf: memoize frecency sorting defaults

dee7108

Avoid interval file-index rebuilds

68cb050

Avoid full script reads for command headers

9f246ce

Optimize root search command scoring

12f951e

perf(runtime): reduce extension and menubar churn

a2737ce

Speed up path-like file search queries

7ed6c2a

Add file search perf harness

dff8539

perf(browser-search): index hot query path

caa78e1

fix(browser-search): narrow indexed nickname candidates

321d103

test: trim benchmark script eof whitespace

644e72d

JustYannicc added 26 commits July 4, 2026 13:20

Merge remote-tracking branch 'refs/remotes/origin/pr/533' into codex/…

d6548bb

…perf-wave2-integration-stack-20260704 # Conflicts: # src/renderer/src/raycast-api/list-runtime-renderers.tsx # src/renderer/src/raycast-api/list-runtime.tsx

Merge remote-tracking branch 'refs/remotes/origin/pr/534' into codex/…

8719131

…perf-wave2-integration-stack-20260704 # Conflicts: # src/renderer/src/CameraExtension.tsx

Merge remote-tracking branch 'refs/remotes/origin/pr/535' into codex/…

143cafe

…perf-wave2-integration-stack-20260704

Merge remote-tracking branch 'refs/remotes/origin/pr/555' into codex/…

ba47b63

…perf-wave2-integration-stack-20260704

Merge remote-tracking branch 'refs/remotes/origin/pr/556' into codex/…

fc4d48e

…perf-wave2-integration-stack-20260704

Merge remote-tracking branch 'refs/remotes/origin/pr/558' into codex/…

c710784

…perf-wave2-integration-stack-20260704

Merge remote-tracking branch 'refs/remotes/origin/pr/572' into codex/…

55817f4

…perf-wave2-integration-stack-20260704 # Conflicts: # src/renderer/src/raycast-api/list-runtime.tsx

fix(list): preserve conditional virtual row behavior

34a04d4

perf(search): reuse renderer ranking work

33194c1

perf(runtime): reduce menu bar and background churn

4c180c6

perf(raycast): reduce runtime hook and registry churn

fbe3ece

perf(files): reduce main-process search and IPC cost

6bd8e50

perf(media): reduce audio and overlay churn

d38e957

perf(startup): reduce renderer and asset load cost

fc80ea6

test(perf): add search regression budgets

531a188

Merge branch 'codex/perf-wave3-renderer-search' into codex/perf-wave3…

73b25ec

…-integration-stack-20260704

Merge branch 'codex/perf-wave3-file-index-main' into codex/perf-wave3…

1411f8b

…-integration-stack-20260704

Merge branch 'codex/perf-wave3-raycast-runtime' into codex/perf-wave3…

ca9d081

…-integration-stack-20260704

Merge branch 'codex/perf-wave3-ai-media-ui-retry' into codex/perf-wav…

81166b3

…e3-integration-stack-20260704

Merge branch 'codex/perf-wave3-validation-harnesses-retry' into codex…

33d0c68

…/perf-wave3-integration-stack-20260704 # Conflicts: # scripts/test-browser-search-performance.mjs # scripts/test-root-search-perf.mjs

test(perf): support CommonJS facade harness exports

206eab8

fix(raycast): guard registry microtask teardown

17fb535

JustYannicc mentioned this pull request Jul 5, 2026

perf(renderer): consolidate Raycast runtime hot paths #599

Open

JustYannicc closed this Jul 5, 2026

JustYannicc mentioned this pull request Jul 5, 2026

perf(runtime): consolidate extension lifecycle and media fixes #601

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

fix(raycast): guard registry microtask teardown#598

fix(raycast): guard registry microtask teardown#598
JustYannicc wants to merge 115 commits into
SuperCmdLabs:mainfrom
JustYannicc:codex/perf-wave4-registry-microtask-lifecycle

JustYannicc commented Jul 4, 2026

Uh oh!

JustYannicc commented Jul 5, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Uh oh!

Conversation

JustYannicc commented Jul 4, 2026

What changed

Why

Compatibility impact

How tested

Performance evidence

Stack validation

Replaces

Uh oh!

JustYannicc commented Jul 5, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant