perf: stream canvas asset serving#588
Closed
JustYannicc wants to merge 115 commits into
Closed
Conversation
…perf-wave2-integration-stack-20260704 # Conflicts: # src/renderer/src/raycast-api/hooks/use-cached-promise.ts
…perf-wave2-integration-stack-20260704 # Conflicts: # src/renderer/src/raycast-api/list-runtime-renderers.tsx # src/renderer/src/raycast-api/list-runtime.tsx
…perf-wave2-integration-stack-20260704 # Conflicts: # src/renderer/src/CameraExtension.tsx
…perf-wave2-integration-stack-20260704
…perf-wave2-integration-stack-20260704
…perf-wave2-integration-stack-20260704
…perf-wave2-integration-stack-20260704
…perf-wave2-integration-stack-20260704 # Conflicts: # src/renderer/src/raycast-api/list-runtime.tsx
…perf-wave2-integration-stack-20260704 # Conflicts: # scripts/bench-script-command-discovery.mjs # scripts/benchmark-file-search-delete-batch.mjs # scripts/lib/script-command-runner-harness.mjs # scripts/lib/ts-import.mjs # scripts/test-file-search-delete-batch.mjs # scripts/test-script-command-runner.mjs # src/main/file-search-index.ts # src/main/main.ts
…perf-wave2-integration-stack-20260704 # Conflicts: # scripts/lib/script-command-runner-harness.mjs # scripts/lib/ts-import.mjs # scripts/test-extension-lifecycle-sandbox.mjs # scripts/test-script-command-runner.mjs # src/main/main.ts # src/renderer/src/ExtensionView.tsx
…perf-wave2-integration-stack-20260704 # Conflicts: # .github/workflows/project-checks.yml # scripts/test-root-search-perf.mjs # src/renderer/src/CameraExtension.tsx # src/renderer/src/raycast-api/list-runtime.tsx
…-integration-stack-20260704
…-integration-stack-20260704
…-integration-stack-20260704
…e3-integration-stack-20260704
…erf-wave3-integration-stack-20260704 # Conflicts: # package.json # scripts/measure-extension-bundle-cache.mjs # scripts/test-icon-runtime-file-icon-cache.mjs # src/main/extension-runner.ts # src/renderer/src/components/HiddenExtensionRunners.tsx # src/renderer/src/raycast-api/icon-runtime-render.tsx
…/perf-wave3-integration-stack-20260704 # Conflicts: # scripts/test-browser-search-performance.mjs # scripts/test-root-search-perf.mjs
Collaborator
Author
|
Superseded by the clean consolidated wave4 renderer/Raycast PR: #599. That branch contains this PR's covered change on current main without the inherited broad-stack noise. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
sc-asset://canvas-lib/...throughnet.fetch(file://...)and wrap the file-backed body with explicit canvas-lib content type and immutable cache headers.getSceneAsyncandgetThumbnailAsynccanvas store reads, and wired the canvas IPC handlers to them.Why
Canvas library asset serving previously read the whole file into the main process before responding. Canvas scene and thumbnail IPC reads also used synchronous file reads. The new paths reduce main-process buffering and avoid synchronous canvas IPC file reads while preserving existing fallbacks.
Compatibility impact
Canvas asset URLs and canvas IPC return shapes are unchanged. Missing canvas-lib files still return 404; empty or malformed canvas-lib paths return 400. Missing/invalid scenes still return an empty scene, and missing thumbnails still return
null.How tested
node --test scripts/test-canvas-asset-serving.mjspnpm testpnpm run build:mainnpm run build:main(local npm shim reports npm is disabled and runs pnpm)src/main/main.ts,src/main/canvas-store.ts, andsrc/main/sc-asset-protocol.ts: no diagnostics foundPerformance evidence
Expanded harness:
node scripts/measure-canvas-asset-event-loop.mjswith 32 MB x8 files, 268435456 bytes served per measurement.The stream cases trade total in-process harness elapsed for lower peak and p95 event-loop delay during serving and avoid constructing a full asset buffer in the protocol handler.
Stack validation
Started from
codex/perf-wave3-integration-stack-20260704stack point206eab8280a2eb91a57e4e74ea6df99e45a55cb4; branchcodex/perf-wave4-canvas-asset-servingwas created from that detached HEAD.Replaces
None.