Skip to content

fix(validation): stabilize and speed project checks#578

Closed
JustYannicc wants to merge 9 commits into
SuperCmdLabs:mainfrom
JustYannicc:codex/consolidate-validation-wave2
Closed

fix(validation): stabilize and speed project checks#578
JustYannicc wants to merge 9 commits into
SuperCmdLabs:mainfrom
JustYannicc:codex/consolidate-validation-wave2

Conversation

@JustYannicc

@JustYannicc JustYannicc commented Jul 4, 2026

Copy link
Copy Markdown
Collaborator

What changed

  • Restores reliable npm validation setup by removing hard macOS-only esbuild platform package pins, keeping Project Checks on npm ci --ignore-scripts without --force, moving electron-liquid-glass to optional dependencies, and adding a macOS runtime dependency guard to postinstall.
  • Adds the root Project Checks workflow, a dedicated typecheck:renderer script, and a CI renderer typecheck step before the renderer build.
  • Speeds the default root-search perf harness by using the validated smaller sample size, while preserving explicit env overrides for heavier benchmark runs.
  • Adds the minimal validated indexed root-search helper support needed by the harness on a clean origin/main base.
  • Adds stamp-based warm native build up-to-date checks for Swift helpers, the native addon, Whisper, Parakeet, and Soulver build inputs.
  • Carries forward the previously validated renderer type-clean, Italian i18n parity, and fork-safe Claude review workflow support required for clean project checks from origin/main.

Why

The validation wave fixes the setup and feedback-loop failures that made project checks unreliable or unnecessarily slow: npm install no longer needs --force, Linux CI can skip Darwin-only runtime packages correctly, renderer semantic type errors are checked explicitly, the root-search harness no longer dominates the script suite by default, unchanged native targets no longer rebuild on warm validation runs, and fork PRs no longer fail Claude review while missing OIDC/secrets.

Compatibility impact

No runtime behavior change is intended from the validation wiring. macOS installs still verify required macOS runtime packages during postinstall, unsupported platforms can omit Darwin-only optional dependencies, renderer type fixes are type-level alignments, same-repository PRs still run Claude review, fork PRs skip the review job when credentials are unavailable, and native build stamps only skip when inputs, commands, framework metadata, package manifests, or outputs are unchanged.

How tested

  • env PATH=/opt/homebrew/opt/node@22/bin:$PATH ELECTRON_SKIP_BINARY_DOWNLOAD=1 SUPERCMD_SKIP_ELECTRON_TESTS=1 /opt/homebrew/opt/node@22/bin/npm ci
  • env PATH=/opt/homebrew/opt/node@22/bin:$PATH node_modules/.bin/tsc -p tsconfig.renderer.json --noEmit --pretty false
  • env PATH=/opt/homebrew/opt/node@22/bin:$PATH node_modules/.bin/tsc -p tsconfig.main.json --noEmit --pretty false
  • env PATH=/opt/homebrew/opt/node@22/bin:$PATH npm run check:i18n
  • env PATH=/opt/homebrew/opt/node@22/bin:$PATH node --test scripts/test-root-search-perf.mjs
  • env PATH=/opt/homebrew/opt/node@22/bin:$PATH CI=true SUPERCMD_SKIP_ELECTRON_TESTS=1 npm test
  • env PATH=/opt/homebrew/opt/node@22/bin:$PATH npm run build:main
  • env PATH=/opt/homebrew/opt/node@22/bin:$PATH npm run build:renderer
  • node --check scripts/build-native.mjs
  • node --check scripts/build-whispercpp.mjs
  • /usr/bin/time -p env PATH=/opt/homebrew/opt/node@22/bin:$PATH /opt/homebrew/opt/node@22/bin/npm run build:native twice
  • git diff --check

Performance evidence

  • Default scripts/test-root-search-perf.mjs now runs with commands=2000, iterations=1, and warmups=0; focused local run completed in about 2.28s with indexed root-search speedup around 23.26x versus the legacy path.
  • Full npm test completed with 25 passing tests, 1 skipped Electron test, and 0 failures; the root-search perf harness completed inside that suite in about 2.09s.
  • Native build first local run took about 14.87s after prior install/build output state; immediate warm rerun took 0.34s and reported every native target up to date.
  • Renderer production build completed in 3.52s.

Stack validation

Replaces

@JustYannicc

Copy link
Copy Markdown
Collaborator Author

Superseded by #600, which consolidates and revalidates this project-checks validation stack on JustYannicc:codex/consolidate-validation-final.

@JustYannicc JustYannicc closed this Jul 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant