fix(validation): stabilize and speed project checks#578
Closed
JustYannicc wants to merge 9 commits into
Closed
Conversation
This was referenced Jul 4, 2026
Collaborator
Author
|
Superseded by #600, which consolidates and revalidates this project-checks validation stack on JustYannicc:codex/consolidate-validation-final. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
npm ci --ignore-scriptswithout--force, movingelectron-liquid-glassto optional dependencies, and adding a macOS runtime dependency guard to postinstall.typecheck:rendererscript, and a CI renderer typecheck step before the renderer build.origin/mainbase.origin/main.Why
The validation wave fixes the setup and feedback-loop failures that made project checks unreliable or unnecessarily slow: npm install no longer needs
--force, Linux CI can skip Darwin-only runtime packages correctly, renderer semantic type errors are checked explicitly, the root-search harness no longer dominates the script suite by default, unchanged native targets no longer rebuild on warm validation runs, and fork PRs no longer fail Claude review while missing OIDC/secrets.Compatibility impact
No runtime behavior change is intended from the validation wiring. macOS installs still verify required macOS runtime packages during postinstall, unsupported platforms can omit Darwin-only optional dependencies, renderer type fixes are type-level alignments, same-repository PRs still run Claude review, fork PRs skip the review job when credentials are unavailable, and native build stamps only skip when inputs, commands, framework metadata, package manifests, or outputs are unchanged.
How tested
env PATH=/opt/homebrew/opt/node@22/bin:$PATH ELECTRON_SKIP_BINARY_DOWNLOAD=1 SUPERCMD_SKIP_ELECTRON_TESTS=1 /opt/homebrew/opt/node@22/bin/npm cienv PATH=/opt/homebrew/opt/node@22/bin:$PATH node_modules/.bin/tsc -p tsconfig.renderer.json --noEmit --pretty falseenv PATH=/opt/homebrew/opt/node@22/bin:$PATH node_modules/.bin/tsc -p tsconfig.main.json --noEmit --pretty falseenv PATH=/opt/homebrew/opt/node@22/bin:$PATH npm run check:i18nenv PATH=/opt/homebrew/opt/node@22/bin:$PATH node --test scripts/test-root-search-perf.mjsenv PATH=/opt/homebrew/opt/node@22/bin:$PATH CI=true SUPERCMD_SKIP_ELECTRON_TESTS=1 npm testenv PATH=/opt/homebrew/opt/node@22/bin:$PATH npm run build:mainenv PATH=/opt/homebrew/opt/node@22/bin:$PATH npm run build:renderernode --check scripts/build-native.mjsnode --check scripts/build-whispercpp.mjs/usr/bin/time -p env PATH=/opt/homebrew/opt/node@22/bin:$PATH /opt/homebrew/opt/node@22/bin/npm run build:nativetwicegit diff --checkPerformance evidence
scripts/test-root-search-perf.mjsnow runs withcommands=2000,iterations=1, andwarmups=0; focused local run completed in about 2.28s with indexed root-search speedup around 23.26x versus the legacy path.npm testcompleted with 25 passing tests, 1 skipped Electron test, and 0 failures; the root-search perf harness completed inside that suite in about 2.09s.Stack validation
origin/mainascodex/consolidate-validation-wave2.15ee435fa6d548dae7cfbcaf6ccf24150566ae5d, perf(validation): speed root search perf harness #574 headba8cced8a8b43ccc9eceeb2356fcfae33c84246e, fix(validation): typecheck renderer in CI #576 headb63e4d4b2d8cdcdbbef03d85c5c788748bf48801, and perf(validation): skip warm native rebuilds #577 head9c751bbba5bb083c322da7739cb4d81daeb3b146.origin/main: indexed root-search helpers for perf(validation): speed root search perf harness #574, renderer type-clean support for fix(validation): typecheck renderer in CI #576, Italian i18n parity for Project Checks, and fork-safe Claude review workflow gating after fix(validation): stabilize and speed project checks #578 exposed the known OIDC failure.pnpm-lock.yaml,pnpm-workspace.yaml, coordinator notes, prompt files, local playbooks, or generated package-manager metadata are included.src/native/soulver-calculator/Package.resolvedchurn locally; it was restored before push and is not included.src/renderer/src.tsxfiles scanned, capped at 50 files, and 0 errors for 14.mjsfiles inscripts.Replaces
fix(validation): restore npm ci for esbuild platform packagesperf(validation): speed root search perf harnessfix(validation): typecheck renderer in CIperf(validation): skip warm native rebuilds