perf(whisper): avoid unused local STT file reads#570
Closed
JustYannicc wants to merge 71 commits into
Closed
Conversation
(cherry picked from commit fb7405f)
(cherry picked from commit 290a0f5)
(cherry picked from commit 3739cb0)
(cherry picked from commit c78d0b9)
…ated-integration-stack
…ated-integration-stack # Conflicts: # src/renderer/src/raycast-api/hooks/use-cached-promise.ts
…ated-integration-stack
…ated-integration-stack # Conflicts: # src/renderer/src/raycast-api/list-runtime-renderers.tsx # src/renderer/src/raycast-api/list-runtime.tsx
…ated-integration-stack # Conflicts: # src/renderer/src/CameraExtension.tsx
…ated-integration-stack
…ated-integration-stack # Conflicts: # src/renderer/src/raycast-api/list-runtime.tsx
…ated-integration-stack
…ated-integration-stack
… into codex/perf-consolidated-integration-stack
Collaborator
Author
|
Superseded by consolidated lifecycle/media wave-2 PR: #575 |
Collaborator
Author
|
Closing as superseded by #575. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
fs.readFileSync(audioPath)until the selected STT provider requires a Buffer;whispercppcontinues to send the captured file path directly.Why
The default local
whispercpppath already transcribes by file path, so the previous eager read created an unused full-file Node heap allocation for native-captured audio.Compatibility impact
No user-visible behavior changes expected. Buffer-backed providers still read the captured WAV once and successful transcriptions still unlink the temp file before removing its directory.
How tested
node --test scripts/test-whisper-file-buffer-read.mjsnode --test scripts/test-whisper-file-buffer-read.mjs scripts/test-native-helper-process-lifecycle.mjs scripts/test-local-model-status-probe-cache.mjs scripts/test-ai-model-status-polling.mjs scripts/test-ai-chat-stream-batching.mjs scripts/test-ai-stream-ipc-batching.mjs scripts/test-use-ai-stream-batching.mjs scripts/test-raycast-ai-abort-listeners.mjs scripts/test-speak-settings-listener.mjs./node_modules/.bin/tsc -p tsconfig.main.json --noEmitgit diff --cached --checkPerformance evidence
The new harness logs an eager-read baseline of
readCalls=1 nodeBufferBytes=73400320; after the changewhispercpplogsreadCalls=0 nodeBufferBytes=0 avoidedNodeBufferBytes=73400320, whileopenailogsreadCalls=1 nodeBufferBytes=73400320.Stack validation
Started from
fork/codex/perf-consolidated-integration-stackat264fb89dc5c867d6c3d77bc4b95e26e235e326ea. Codex LSP diagnostics onsrc/main/main.tsandsrc/main/whisper-transcribe-file.ts: no diagnostics found.Replaces
None