perf(script): clear script command timeout on output limit#560
Closed
JustYannicc wants to merge 71 commits into
Closed
perf(script): clear script command timeout on output limit#560JustYannicc wants to merge 71 commits into
JustYannicc wants to merge 71 commits into
Conversation
(cherry picked from commit fb7405f)
(cherry picked from commit 290a0f5)
(cherry picked from commit 3739cb0)
(cherry picked from commit c78d0b9)
…ated-integration-stack
…ated-integration-stack # Conflicts: # src/renderer/src/raycast-api/hooks/use-cached-promise.ts
…ated-integration-stack
…ated-integration-stack # Conflicts: # src/renderer/src/raycast-api/list-runtime-renderers.tsx # src/renderer/src/raycast-api/list-runtime.tsx
…ated-integration-stack # Conflicts: # src/renderer/src/CameraExtension.tsx
…ated-integration-stack
…ated-integration-stack # Conflicts: # src/renderer/src/raycast-api/list-runtime.tsx
…ated-integration-stack
…ated-integration-stack
… into codex/perf-consolidated-integration-stack
Collaborator
Author
|
Superseded by consolidated lifecycle/media wave-2 PR: #575 |
Collaborator
Author
|
Closing as superseded by #575. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
finalizepath so stdout/stderr output-limit early settlement releases the timer immediately.child_process.spawnmock.Why
Output-limit settlement killed and resolved the subprocess result but left the original timeout armed until its full timeout window elapsed. Centralizing cleanup in
finalizekeeps close, error, timeout, and output-limit paths single-settle while preventing retained timeout handles.Compatibility impact
No user-visible behavior changes. Exit codes, output-limit messages, timeout messages, subprocess killing, and result shaping are preserved.
How tested
src/main/script-command-runner.ts: no diagnostics found.node --test scripts/test-script-command-runner.mjs scripts/test-exec-command-timeout-cleanup.mjs: 12 tests passed.pnpm test: 240 tests passed.pnpm run build:main: passed.Performance evidence
Fake timer/process instrumentation for the output-limit early-finalize path reports:
Stack validation
Started from
fork/codex/perf-consolidated-integration-stackat264fb89dc5c867d6c3d77bc4b95e26e235e326ea; implementation branch iscodex/perf-script-command-timeout-cleanupatf5cf07c.Replaces
None