perf(settings): clean up Ollama pull listeners#553
Closed
JustYannicc wants to merge 1 commit into
Closed
Conversation
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why
Remounting Settings > AI could leave stale pull listeners behind, multiplying pull progress, completion refresh, and error callbacks on future pulls.
Compatibility impact
Existing callers can keep ignoring the return value. The only renderer call site now uses it for cleanup. Single-pull UX and final Ollama status refresh behavior are preserved.
How tested
Stack validation
Clean PR branch from SuperCmdLabs/SuperCmd:main with one cherry-picked fix commit. It does not include the integration-stack commits.