perf(files): map launcher file result commands by path#552
Closed
JustYannicc wants to merge 1 commit into
Closed
Conversation
Collaborator
Author
|
Superseded by #555, which now includes this launcher file-result command map fix and preserves the first duplicate-path command semantics/evidence. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Mapfrom launcher file result paths to their generated commands.fileResultCommandswith.findfor each result.node --testharness.Why
Launcher file candidate assembly can receive up to 3000 file results. Looking up each result command with
.findmakes that path O(n^2), while a path map keeps the assembly O(n) and preserves the existing path matching behavior.Compatibility impact
No launcher behavior is removed. File result order, strict path matching, command data, scoring, and missing-command fallback behavior are preserved. Duplicate command paths continue to use the first command, matching the old
.findsemantics.How tested
.findmedian 12.214ms (min 11.199, max 55.398), path map median 0.100ms (min 0.083, max 0.656), equal checksum 11445000..findmedian 18.121ms (min 17.277, max 31.698), path map median 0.024ms (min 0.023, max 0.324), equal checksum 11445000.node --test scripts/test-launcher-file-result-command-map.mjson the clean PR branch: full candidate assembly map median 25.097ms vs find-backed median 45.257ms, equal checksum 99347250../node_modules/.bin/tsc -p tsconfig.renderer.json --noEmit --pretty falsewas run on the clean PR branch and fails on existingorigin/mainrenderer type errors unrelated to this file-result lookup change.git diff origin/main --checkStack validation
Clean branch from
origin/main; this PR is one commit ahead and is not stacked on #530-#535.