fix(raycast): guard stale promise hook runs#551
Closed
JustYannicc wants to merge 38 commits into
Closed
Conversation
…s' into codex/perf-consolidated-integration-stack
…nd-menubar' into codex/perf-consolidated-integration-stack # Conflicts: # src/renderer/src/raycast-api/hooks/use-cached-promise.ts
…emoji' into codex/perf-consolidated-integration-stack # Conflicts: # src/renderer/src/raycast-api/list-runtime-renderers.tsx # src/renderer/src/raycast-api/list-runtime.tsx
… into codex/perf-consolidated-integration-stack
…tus' into codex/perf-consolidated-integration-stack
… into codex/perf-consolidated-integration-stack # Conflicts: # src/renderer/src/CameraExtension.tsx
Collaborator
Author
|
Superseded by consolidated upstream PR #555. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
usePromiseanduseCachedPromiseso stale completions cannot updatedata,error,isLoading,onData, oronErrorwhen callers do not passabortable.Why
Default Raycast-style hook usage can overlap executions through
revalidate()or argument changes without passingabortable. The previous current-run check treated every non-abortable run as current, so an older completion could overwrite a newer result or callback state.Compatibility impact
AbortController.How tested
node --test scripts/test-abortable-promise-hooks.mjs: both defaultusePromiseanduseCachedPromiselet stale data overwritelatest.node --test scripts/test-abortable-promise-hooks.mjsnow passes 12/12../node_modules/.bin/tsc -p tsconfig.renderer.json --noEmit --pretty falseStack validation
This is a stacked draft PR. It depends on #530, #531, #532, #533, #534, #535, and
JustYannicc:codex/perf-consolidated-integration-stack.A clean
codex/perf-promise-latest-run-guards-prbranch fromorigin/mainwas attempted, but cherry-picking this scoped commit conflicted becauseorigin/maindoes not yet contain the abortable hook lifecycle changes orscripts/test-abortable-promise-hooks.mjs.