perf(grid): binary-search visible virtual rows#544
Closed
JustYannicc wants to merge 38 commits into
Closed
Conversation
…s' into codex/perf-consolidated-integration-stack
…nd-menubar' into codex/perf-consolidated-integration-stack # Conflicts: # src/renderer/src/raycast-api/hooks/use-cached-promise.ts
…emoji' into codex/perf-consolidated-integration-stack # Conflicts: # src/renderer/src/raycast-api/list-runtime-renderers.tsx # src/renderer/src/raycast-api/list-runtime.tsx
… into codex/perf-consolidated-integration-stack
…tus' into codex/perf-consolidated-integration-stack
… into codex/perf-consolidated-integration-stack # Conflicts: # src/renderer/src/CameraExtension.tsx
Collaborator
Author
|
Superseded by consolidated upstream PR #555. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why
getVisibleVirtualRowspreviously scanned every virtual row on each viewport update. The new lookup keeps scroll updates tied to logarithmic bound checks plus the visible slice, which avoids total-row scaling for large grids.Compatibility impact
row.top + row.height >= start && row.top <= end.How tested
node scripts/test-grid-virtualization.mjspnpm exec tsc -p tsconfig.renderer.json --noEmitpnpm test(163 passed, 1 skipped)src/renderer/src/raycast-api/grid-runtime-virtualization.ts: no errors; references are declaration plus thegrid-runtime.tsximport/use.Stack validation
Draft until the consolidated performance stack lands. Depends on consolidated PRs #530-#535 and integration branch
JustYannicc:codex/perf-consolidated-integration-stack.This branch is intentionally stacked on that integration branch: the virtualization helper and focused test script are introduced by the dependency stack, so a clean
origin/maincherry-pick cannot represent only this fix yet.