ci(claude): fix review action on fork PRs#519
Closed
JustYannicc wants to merge 1 commit into
Closed
Conversation
JustYannicc
marked this pull request as ready for review
July 3, 2026 19:33
Collaborator
Author
|
Superseded by #532 (fix(validation): restore project checks), which consolidates this validation/build change with the related source PRs. Closing this PR in favor of the upstream replacement. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
.github/workflows/claude-code-review.ymlsoclaude-reviewruns only for same-repository pull requests.contents,pull-requests,issues, andid-token: writepermissions unchanged for same-repo PRs.Why
mainalready grantsid-token: write, but fork-basedpull_requestruns still cannot access the OIDC/secrets surface required byanthropics/claude-code-action@v1.JustYannicc/SuperCmdand itsclaude-reviewcheck fails while requesting OIDC withUnable to get ACTIONS_ID_TOKEN_REQUEST_URL env variable.ifmakes fork PRs skip the job. GitHub reports skipped jobs as successful checks, avoiding a red required check.Compatibility impact
pull_requestworkflow.pull_request_target, which would expose elevated base-repository credentials around untrusted fork PR content and needs a broader security design before enabling.How tested
gh run view 28679751403 --job 85060643677 --log-failedshowsCould not fetch an OIDC tokenandUnable to get ACTIONS_ID_TOKEN_REQUEST_URL env variable.JustYannicc/SuperCmd:codex/perf-grid-virtualizationintoSuperCmdLabs/SuperCmd:main.YAML.load_file.actionlintv1.7.12 on all repo workflows: pass.git diff --check: pass.