perf(emoji): cache caret session state#507
Closed
JustYannicc wants to merge 1 commit into
Closed
Conversation
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
node --test 'scripts/test-*.mjs'suite.Why
The native emoji trigger monitor previously asked
NSWorkspace.shared.frontmostApplicationandAXCaretQuery.current()for every emitted query update. Typing a multi-character emoji search could therefore repeat frontmost and Accessibility caret work on every character/backspace.Metrics
Focused stubbed measurement for typing
:fireplus one backspace:No-rect results intentionally do not cache, so those continue to re-query until a usable rect is available or the session is dismissed.
Validation
swiftc -O -o /tmp/supercmd-native-check/emoji-trigger-monitor src/native/emoji-trigger-monitor.swift src/native/ax-caret-query.swift src/native/emoji-caret-session-cache.swift -framework AppKit -framework ApplicationServicesnode scripts/test-emoji-caret-session.mjsnode --test 'scripts/test-*.mjs'(passes; live Electron crash-recovery test is skipped in this environment)./node_modules/.bin/tsc -p tsconfig.main.jsonnode scripts/check-i18n.mjs(strict locales pass; pre-existing Italian missing-key warnings remain)git diff --checkNotes and risks
swiftccompile is clean.node scripts/build-native.mjscompiled the Swift helpers, then failed in the existing native addon step becausenode-addon-apiwas unavailable under this machine's pnpm/npx wrapper setup.