perf(notes): coalesce autosave persistence#497
Closed
JustYannicc wants to merge 1 commit into
Closed
Conversation
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
notesCacheas the authoritative in-memory state for immediate reads while persistence drains in the background.flushNotesToDisk()/hasPendingNotesSave()and defer Electron quit only when a Notes save is pending or in-flight.Before / After Evidence
loopMs=23.77,syncWriteMs=23.11.loopMs=2.62,syncWriteMs=0.00.Validation
node --test scripts/test-notes-async-saves.mjsnode --test scripts/test-*.mjs(26 pass, 1 live Electron test skipped because Electron is not launchable here)./node_modules/.bin/tsc -p tsconfig.main.jsonsrc/main: 0 errorsnode scripts/check-i18n.mjs(exits 0; reports existing Italian locale gaps forsettings.ai.whisper.vocabularyandsettings.extensions.appSearchScope)git diff --checkRemote Checks
claude-reviewfailed before running review logic because the action could not fetch an OIDC token:Unable to get ACTIONS_ID_TOKEN_REQUEST_URL env variable; log suggests addingid-token: writeto workflow permissions.Risks / Notes