perf(frecency): memoize sorting defaults#493
Closed
JustYannicc wants to merge 1 commit into
Closed
Conversation
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
useFrecencySortingkey resolver so stable rerenders do not invalidateuseMemo.Date.now()for each score.Evidence
node --test scripts/test-use-frecency-sorting.mjsfailed with stable rerender comparisons increasing4 -> 8, and one sort readingDate.now()8times instead of1.node --test scripts/test-use-frecency-sorting.mjspasses all 3 tests.Validation
npm testpasses: 27 passed, 1 skipped.npm run check:i18nexits 0; it still reports pre-existing Italian locale gaps forsettings.ai.whisper.vocabularyandsettings.extensions.appSearchScope.npm run build:mainpasses.npm run build:rendererpasses.Risks
idvalues explicitly; object property access already coerced those keys for persisted records, so existing storage keys should continue to match.