perf(audio): avoid idle buffer conversion#491
Closed
JustYannicc wants to merge 1 commit into
Closed
Conversation
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AVAudioConverterwork on warm idle audio taps unless a meter update is dueEvidence
Focused temporary instrumentation around
processBuffercounted converted, recorded, and metered buffers over matching 1.2s windows:This removes idle converter work while preserving recording conversion and meter cadence in the measured run.
Checks
mcp__lsp.diagnosticsonsrc/native/audio-capturer.swift: no errorsswiftc -O -o /tmp/supercmd-audio-capturer-final src/native/audio-capturer.swift -framework AVFoundation -framework Foundation: passedgit diff --check: passednode scripts/check-i18n.mjs: completed; existingitlocale missing keys were reported and are unrelated to this native-only changenpm run build:native: blocked by local policy; npm is disabled on this Mac, pnpm attempted install, then failed withERR_PNPM_IGNORED_BUILDSRisks