perf(files): optimize file search delete batches#489
Closed
JustYannicc wants to merge 1 commit into
Closed
Conversation
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Benchmark
Command:
node scripts/benchmark-file-search-delete-batch.mjsSynthetic scenario: 68,162 index entries, 4,041 nested delete paths, 8,041 tombstoned entries.
Validation
node --test scripts/test-file-search-delete-batch.mjsnode --test 'scripts/test-*.mjs'(passes; live Electron test skipped because Electron is not launchable here)src/main/file-search-index.ts: no errorspnpm run build:mainpnpm run check:i18nexited 0; it still reports pre-existing Italian locale gaps forsettings.ai.whisper.vocabularyandsettings.extensions.appSearchScope, and this PR does not touch user-facing stringsRisks
pathToEntryIdas before, so re-added paths can clear the deleted flag throughindexEntry.