Keep keyboard focus in the grid on Home/End jumps - #13021
Merged
Conversation
Since row containers took keyboard focus (#13015), a long Home/End scroll recycles the focused TableViewRow and focus silently drops out of the grid - the main window key handler is gated on IsSubtitleGridFocused, so pressing End and then Home left the last row selected. Re-focus the newly selected row after the scroll in SelectAndScrollToRow (guarded so non-grid callers never steal focus), in the Shift+Home/End/ Page selection path, and in the shared AttachHomeEndNavigation helper. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #13017. Since row containers took keyboard focus (#13015), a long Home/End scroll recycles the focused TableViewRow container and keyboard focus silently drops out of the grid. The main window key handler is gated on IsSubtitleGridFocused, so pressing End and then Home left the last row selected.
Fixes:
SelectAndScrollToRowre-focuses the newly selected row after the scroll, guarded by the grid's prior focus state so other callers never steal focus from the text box.HandleShiftArrowSelection(Shift+Home/End/PageUp/PageDown) re-focuses the moving end of the selection.TableViewExtras.AttachHomeEndNavigation(shared helper for the other grids) re-focuses the target row.All three post the refocus via the dispatcher so it runs after layout has realized the target container;
FocusRowfalls back to focusing the TableView itself otherwise.🤖 Generated with Claude Code