Repository navigation
The default dispatch was broken by a GitHub Actions falsy ternary - #62
Merged
Merged
Conversation
StepenkoAnatoli
commented
Sep 22, 2026
StepenkoAnatoli
commented
Owner
Found by launching the first research collection since #58, which used the default search_transport and died: unknown search provider "auto". Known: firecrawl-cli, http-keyless, serpapi The wiring was: RESEARCH_KIT_SEARCH_TRANSPORT: ${{ inputs.search_transport == 'auto' && '' || inputs.search_transport }} In GitHub Actions the EMPTY STRING IS FALSY, so when the condition is true the true-branch collapses and the expression yields its third operand. It passed the literal "auto" into the ladder, which correctly refuses it as an unknown provider. Why it survived review and CI: every run that exercised the feature pinned an explicit provider, because the whole point of the input was comparing serpapi against firecrawl-cli. The DEFAULT path - the one almost every real dispatch takes - was never run until a research collection tried it. The feature was tested; its default was not. The input is now carried raw as SEARCH_TRANSPORT_INPUT and blanked in the shell, where an empty string is just an empty string: if [ "${SEARCH_TRANSPORT_INPUT:-auto}" != "auto" ]; then export RESEARCH_KIT_SEARCH_TRANSPORT="$SEARCH_TRANSPORT_INPUT" fi A guard scans every workflow for the pattern. It earned its place twice: on first run it flagged the explanatory COMMENT that warns about the footgun, because a check that cannot tell a value from prose about the value reports the documentation as the defect. Comment lines are skipped now, and the guard was confirmed red against the real expression and green without it. 860 -> 861 tests. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.