Repository navigation
test(selftest-cli): give the group child small groups and the suite's own time - #435
Merged
Merged
Conversation
… own time what changed: The two multi-group checks in selftest-cli.test.mjs run `ordering witness` instead of `warc similarity`, the child's spawnSync timeout is the harness's TEST_TIMEOUT instead of a fixed 60000 ms, and a failed check names the child's error (ETIMEDOUT) before its output. why: The child for `warc similarity` takes 31-34 s on an idle PC, so under the commit gate's load it ran past the fixed 60 s, was killed with status null and failed the full suite (2026-10-21, the hand-run gate for the browser /stalled fix); the fixed value also ignored FETCHPROOF_TEST_TIMEOUT. Set aside: raising the fixed timeout alone, which keeps a 30 s child inside every run and only moves the line. Both new groups read only the kit; action-pins was tried and set aside because it reads ../.github. what you verified: Red first on the unchanged test with a preload that holds the two-group child 35 s without CPU: 1 passed, 2 failed (`null !== 0`) in 124.8 s. Green with the same hold: 3 passed, 0 failed in 89.7 s. Alone: 3 passed, 0 failed in 18.2 s while another suite ran (64.5 s before). Forced timeout (FETCHPROOF_TEST_TIMEOUT=5000, child held 8 s): both checks fail and say ETIMEDOUT. git diff --check clean. Full suite: the renamed kit's gate run by hand on 763ea36 (`node fetchproof/bin/gate.mjs --gate commit`) allowed the commit in 2647 s; the installed hook is the pre-rename kit's and skips the suite on fetchproof/ paths. what you got wrong: I first picked action-pins as the second group for its speed (1.8 s with ordering) before checking what it reads; it imports ../.github/scripts, outside the kit, so it was replaced by witness before any commit. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
selftest-cli > multiple valid groups still run every matching test file, which failed the full suite under the commit gate's load: its child ran past a fixed 60 s timeout. The fix is to the test only.What changed
fetchproof/test/selftest-cli.test.mjs:ordering witnessinstead ofwarc similarity. Both read only the kit, and the child takes a few seconds.spawnSynctimeout is the harness'sTEST_TIMEOUT(FETCHPROOF_TEST_TIMEOUT, default 60 s) instead of a fixed 60000 ms.ETIMEDOUT) before its output, instead of a barenull !== 0.Why
warc similaritytakes 31-34 s on an idle PC. Under the gate's load on 2026-10-21 (the hand-run gate for the browser/stalledfix), it ran past 60 s, was killed with status null, and failed the suite.FETCHPROOF_TEST_TIMEOUT, which the gate's operator raises on a slow machine.action-pinsas the second group (1.8 s withordering): it reads../.github/scripts, outside the kit.What you verified
null !== 0) in 124.8 s.FETCHPROOF_TEST_TIMEOUT=5000, child held 8 s): both checks fail and sayETIMEDOUT.git diff --checkis clean.node fetchproof/bin/gate.mjs --gate commit): allowed in 2647 s. The installed hook is still the pre-rename kit's, which skips the suite onfetchproof/paths. So the gate was run by hand first, and the commit then went through that hook.selftest.mjs selftest-clion the rebased head: 3 passed, 0 failed in 6.3 s. CI'ssuiteis the full run on this head.What I got wrong and fixed
action-pinsfor its speed before checking what it reads. It was replaced bywitnessbefore the commit.🤖 Generated with Claude Code