Repository navigation
fix: reject empty remote collection values - #417
Merged
Merged
Conversation
what changed Added repository, topic, client-ref, prior and prefer to collect-remote's existing value validation. Added CLI regressions for empty equals/separate spellings and bare optional flags, and kept the architecture map, changelog and test inventory current. why Fixes #287. Invalid empty input reached output-directory creation and token lookup instead of being refused by name. This uses the existing value checker and leaves absent-required-flag and run-pickup behavior intact. what it touched research-kit/bin/collect-remote.mjs, research-kit/test/cli.test.mjs, docs/ARCHITECTURE.md, CHANGELOG.md and research-kit/README.md. No new flags, file formats or collection routes. what you verified verified: before-fix CLI probes reproduced token lookup for empty repository, topic and prior values. verified: root preflight PASS and handoff OK on the current base. expected: the normal commit gate will run the full offline suite and check the staged architecture map and inventory; final results accompany the PR. what you got wrong and fixed nothing to report. The deliberate red regression reproduces the existing issue, rather than an implementation failure.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Empty
--repository=,--topic=,--client-ref=,--prior=and--prefer=now fail by name before output-directory creation or token lookup. The same refusal covers a separate empty argument and bare optional value flags.Fixes #287.
what changed
Added repository, topic, client-ref, prior and prefer to collect-remote's existing value validation. Added CLI regressions for empty equals/separate spellings and bare optional flags, and kept the architecture map, changelog and test inventory current.
why
Fixes #287. Invalid empty input reached output-directory creation and token lookup instead of being refused by name. This uses the existing value checker and leaves absent-required-flag and run-pickup behavior intact.
what it touched
research-kit/bin/collect-remote.mjs, research-kit/test/cli.test.mjs, docs/ARCHITECTURE.md, CHANGELOG.md and research-kit/README.md. No new flags, file formats or collection routes.
what you verified
verified: before-fix CLI probes reproduced token lookup for empty repository, topic and prior values. verified: root preflight PASS and handoff OK on the current base. verified: the ordinary git commit gate ran the full staged offline suite and allowed commit 6e0021a. The local gate permits unavailable capabilities under ADR-0108 and deletes its detailed result; passed/unsupported totals are therefore not claimed here. verified: before-fix CLI group had 127 passed and the one added regression failed in cwd Research-Kit-issue-287. verified: all seven required CI jobs passed for head
6e0021a2ed514a8e4fa77ae10b07624482098bd7in offline-suite run #776. The completed Node 24 log reports 1,846 passed, 0 failed in 180.0s.what you got wrong and fixed
nothing to report. The deliberate red regression reproduces the existing issue, rather than an implementation failure.