Repository navigation
fix(artifact): reject invalid format versions as malformed - #403
Merged
Merged
Conversation
what changed: Require a string numeric dotted version before classifying its major. Missing, ill-typed, malformed and below-oldest versions yield MANIFEST-SCHEMA/FAIL with a regeneration remedy; only newer majors yield FORMAT-UNSUPPORTED/INCOMPLETE. why: Invalid manifests were incorrectly described as newer packages with an upgrade remedy. Preserve the distinction between corruption and an unimplemented format. what it touched: artifact validator/tests, architecture, changelog and README test inventory. No supported format or exit-code mapping changed. what you verified: verified - red-first 45 passed/1 expected failure; then 46 artifact-validator tests passed. Handoff OK, preflight PASS, doctor READY. Full gate is running. what you got wrong and fixed: nothing to report.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Malformed, missing, ill-typed, and below-oldest formatVersion values were described as newer artifacts with an upgrade remedy. The validator now requires a numeric dotted version string before classifying the major: invalid versions are MANIFEST-SCHEMA/FAIL with a regeneration remedy, while only a valid newer major is FORMAT-UNSUPPORTED/INCOMPLETE.
Fixes #361
what changed: Added strict dotted-version parsing before major classification and regression coverage for missing, null, numeric, array, empty, non-numeric, below-oldest, and valid future versions.
why: Keep malformed manifests distinct from packages in a newer format that this validator cannot yet read.
what it touched: artifact validator and tests, architecture map, changelog and README test inventory. Supported formats and exit-code mapping are unchanged.
what you verified: verified - red-first 45 passed and 1 expected failure; then 46 artifact-validator tests passed. Handoff OK, preflight PASS, doctor READY. The required full commit gate accepted 63e0e52. GitHub CI passed all seven required jobs (run 38437560909).
what you got wrong and fixed: nothing to report.