Repository navigation
fix(timeline): keep multiline errors in one table row - #393
Merged
Merged
Conversation
what changed: Folded whitespace in timeline details before escaping table pipes. Added CR/LF, trailing-newline and pipe regressions, and regenerated the root TIMELINE.md from its existing corpus. why: Firecrawl's trailing stderr newline split failure rows across lines, including four rows in the committed root timeline. Normalize the derived table cell, preserving the underlying evidence. No alternative design was set aside. what it touched: timeline.mjs, hardening tests, architecture row, changelog, README inventory and derived research/TIMELINE.md. The provenance ledger and raw captures were not edited; their content remains evidence. what you verified: verified - red-first reproduction (65 passed, one expected failure, two unsupported capabilities), then 66 passing hardening tests with zero failures and two unsupported symlink capabilities; timeline regeneration produced 60 events and its diff joins exactly the four broken failure rows; ledger SHA256 stayed unchanged; handoff OK and preflight PASS. The required full suite runs in the commit gate before acceptance. what you got wrong and fixed: nothing to report.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Multiline fetch errors split timeline rows across lines, including four failure rows in the root corpus. Timeline details now fold whitespace before table-pipe escaping. Regenerated research/TIMELINE.md from the existing corpus; its provenance ledger is unchanged.
Fixes #354
what changed: Normalized derived detail cells, added CR/LF and pipe regressions, and repaired the generated root table.
why: Keep each recorded event in one readable Markdown row without rewriting the underlying evidence. No alternative design was set aside.
what it touched: timeline.mjs, hardening tests, architecture row, changelog, README inventory and derived TIMELINE.md.
what you verified: verified - red-first reproduction, then 66 passing hardening tests with zero failures and two unsupported symlink capabilities; regenerated 60 events, with only the four broken rows joined; ledger SHA256 unchanged; handoff OK and preflight PASS. The required full-suite commit gate accepted this commit.
what you got wrong and fixed: nothing to report.
Full offline gate on Windows / Node 24.20.0: 1778 passed, 0 failures, 12 unsupported capabilities waived by the gate's documented local policy; 1156.4 seconds. No hook override or fail-open acceptance.