Repository navigation
fix(mcp): report invalid downloads as validation failures - #391
Merged
Merged
Conversation
what changed: A non-PASS corpus download returns redacted validator codes, messages and remedies in its text result, with no resource link or review instructions. Build authorization remains false. Expanded existing invalid-package coverage over FAIL, BLOCKED and INCOMPLETE, including unreadable and contradictory inputs. why: Corrupt downloads were described as collected corpora awaiting review, while their actual remedies were absent from the text. Keep the existing approved/collected texts for PASS only. No alternative design was set aside. what it touched: mcp.mjs, existing MCP tests, architecture row and changelog. No new status, tool or field; inventory unchanged. what you verified: verified - red-first MCP reproduction (46 passed, one expected failure), then 47 passing MCP tests; handoff OK and preflight PASS in this checkout. The required full suite runs in the commit gate before acceptance. what you got wrong and fixed: nothing to report.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fetch_corpus described failed, unreadable or unsupported downloads as collected corpora awaiting review and linked them as ZIP packages. Non-PASS validation now returns the validator's codes, messages and remedies in redacted text, with no resource link or review instructions. PASS retains the existing approved/collected descriptions.
Fixes #371
what changed: Added the non-PASS result branch, kept buildAuthorized false, and expanded the existing invalid-package regression across FAIL, BLOCKED and INCOMPLETE.
why: A corrupt download needs the validator's remedy before it can be reviewed. No alternative design was set aside.
what it touched: mcp.mjs, MCP tests, architecture row and changelog. No new status, tool or field.
what you verified: verified - red-first reproduction, then 47 passing MCP tests; handoff OK and root preflight PASS. The required full-suite commit gate accepted this commit.
what you got wrong and fixed: nothing to report.
Full offline gate on Windows / Node 24.20.0: 1777 passed, 0 failures, 12 unsupported capabilities waived by the gate's documented local policy; 2012.9 seconds. No hook override or fail-open acceptance.