Repository navigation
fix(download): resolve output folders before returning links - #390
Merged
Merged
Conversation
what changed: usableOutDir resolves its argument and returns the absolute path it checked. MCP fetch_corpus passes that path to the shared downloader. Added download and MCP regressions for relative nested folders and links to the actual saved file. why: A relative download folder previously produced a root-anchored file URI that named a different location. Use the same resolved folder for access checks, writing and linking. No alternative design was set aside. what it touched: dispatch.mjs, mcp.mjs, dispatch/MCP tests, architecture rows, changelog and test inventory. No new option or path semantics for absolute folders. what you verified: verified - red-first reproduction (79 passed, two expected failures), then dispatch/MCP regressions (81 passed, zero failed); handoff OK and preflight PASS in this checkout. The required complete suite runs in the commit gate before acceptance. what you got wrong and fixed: nothing to report.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relative MCP output folders produced file links rooted at the filesystem root instead of the folder where the download was saved. Resolve the folder in the shared usableOutDir helper and pass the resulting absolute path through MCP to the downloader. The saved file and returned link now identify the same location.
Fixes #372
what changed: Resolved output-folder checks and added shared-download/MCP regressions for relative nested paths and an existing saved file behind the link.
why: Restore the resource link's existing promise to identify the download. No alternative design was set aside.
what it touched: dispatch.mjs, mcp.mjs, their tests and architecture rows, changelog and README inventory. No new public option.
what you verified: verified - red-first reproduction and 81 passing dispatch/MCP tests; handoff OK and root preflight PASS. The required full-suite commit gate accepted this commit.
what you got wrong and fixed: nothing to report.
Full offline gate on Windows / Node 24.20.0: 1779 passed, 0 failures, 12 unsupported capabilities waived by the gate's documented local policy; 1543.7 seconds. No hook override or fail-open acceptance.