Repository navigation
fix(doctor): respect disabled proxy startup choices - #387
Merged
Merged
Conversation
what changed: Added a shared startup-choice reader used by runtime selection and doctor; warn when NODE_USE_ENV_PROXY is not 1 or startup flags disable proxies. Regression coverage includes environment values, flag precedence and unchanged no-override behavior. why: doctor promised proxy routing when the operator had explicitly left it off. Restore ADR-0047's diagnostic and startup-choice contract; no alternative design was set aside. what it touched: runtime.mjs, doctor.mjs, proxy/doctor tests, architecture rows, changelog and test inventory. No new public flag, config key or domain term. what you verified: verified - red-first direct doctor assertion. The targeted doctor/proxy tests and required complete offline suite run before commit acceptance. what you got wrong and fixed: mistake - running six full suites concurrently exceeded the default 3900-second budget; where - local commit validation on this Windows host; impact - affected hooks refused commits before publication; cause - excess concurrent subprocess and filesystem work; fix - retry one commit at a time with the ADR-0142 timeout extension (RESEARCH_KIT_GATE_TIMEOUT=7920); verified - the required full-suite commit gate accepted the commit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With a configured proxy, doctor reported success when
NODE_USE_ENV_PROXY=true,0, another non-1value, or--no-use-env-proxyleft requests direct. Share the runtime's startup-choice reader with doctor and warn for explicit disabled choices. Enabled choices retain the passing diagnostic; command-line flags outrank NODE_OPTIONS and the variable. The operator choice is preserved and raw values are never echoed.Fixes #381
what changed: A shared startup-choice reader, the existing proxy warning, and regression coverage for disabled values and flag precedence.
why: Align diagnostics with Node startup routing while retaining ADR-0047's no-override rule. Node's CLI documentation describes the enabling value and flag precedence. No alternative design was set aside.
what it touched:
lib/runtime.mjs,lib/doctor.mjs, proxy/doctor tests, architecture rows, changelog and test inventory. No new public flag, config key or domain term.what you verified: verified - red-first reproduction, passing doctor/proxy tests, and acceptance by the required complete offline suite in the repository commit gate.
what you got wrong and fixed: mistake - running six full suites concurrently exceeded the default 3900-second budget; where - local commit validation on this Windows host; impact - affected hooks refused commits before publication; cause - excess concurrent subprocess and filesystem work; fix - retry one commit at a time with the ADR-0142 timeout extension (RESEARCH_KIT_GATE_TIMEOUT=7920); verified - the required full-suite commit gate accepted the commit.
Full-suite detail: verified - 1779 passed, 0 failed, 12 unsupported capabilities on win32/Node 24.20.0 in 1271.8 seconds. The gate's documented local unsupported-capability opt-in was used; CI exercises its supported platforms separately.