Skip to content

test(cli): every bin that calls refuseUnknownFlags has a row in the unknown-flag table #285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
StepenkoAnatoli merged 1 commit into from
Oct 11, 2026
Merged

test(cli): every bin that calls refuseUnknownFlags has a row in the unknown-flag table #285

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,10 @@ Each release of Research-Kit, newest first. The version is `KIT_VERSION` in

## Unreleased

- The suite's "every CLI refuses a flag it does not know" table now covers `measure`,
`export-warc`, `artifact` and `panel`, and fails by name when a file under `bin/` calls
`refuseUnknownFlags` without a row (#271). Tests only; no CLI changed.

- `doctor` reports Node 22.13.0 through 22.22.0 as a failing Node line (#282, ADR-0159):
those builds' `TextDecoder` reads `windows-1252` as Latin-1 (nodejs/node#60888), so a
page's euro signs, curly quotes and dashes were captured as control characters with no
Expand Down
13 changes: 13 additions & 0 deletions research-kit/test/cli.test.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -965,7 +965,20 @@ test('every CLI refuses a flag it does not know, before it does anything', () =>
['evidence-context.mjs', ['--all']],
['audit.mjs', []], ['brief.mjs', []], ['doctor.mjs', []], ['gate.mjs', []], ['handoff.mjs', []],
['preflight.mjs', []], ['prior.mjs', []], ['research.mjs', ['--dry-run']], ['bundle.mjs', []],
// Added 2026-10-11 (#271). measure and export-warc refuse before they look for a project.
// artifact with no subcommand names the unknown flag and exits 2; with a subcommand the
// refusal is exit 3 (BLOCKED) and artifact-cli.test.mjs covers it. panel refuses before
// it listens on anything.
['measure.mjs', []], ['export-warc.mjs', []], ['artifact.mjs', []], ['panel.mjs', []],
];
// Found 2026-10-11 (#271): four CLIs called refuseUnknownFlags and had no row here, so a new
// CLI could be forgotten again. Every file under bin/ that refuses unknown flags by that name
// must have a row; a CLI with its own refusal (collect-remote, disclosure, mcp-server,
// path-authority) is covered by its own tests.
const refusing = fs.readdirSync(path.join(KIT_ROOT, 'bin'))
.filter((name) => name.endsWith('.mjs') && /refuseUnknownFlags\(/.test(fs.readFileSync(path.join(KIT_ROOT, 'bin', name), 'utf8')));
const missing = refusing.filter((name) => !cases.some(([bin]) => bin === name));
assert.deepEqual(missing, [], `these CLIs refuse unknown flags but have no row in this table: ${missing.join(', ')}`);
for (const [bin, args] of cases) {
const root = planned('flags');
const r = run(bin, [...args, '--no-such-flag'], { root, env: { HOME: home, USERPROFILE: home, RESEARCH_KIT_CONFIG: path.join(home, 'c.json') } });
Expand Down
Loading