Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,16 @@ Each release of Research-Kit, newest first. The version is `KIT_VERSION` in

## Unreleased

- `artifact create` and `artifact validate` refuse a value flag given no value (`--<name>
needs a value`, exit 3) before anything is read or written (#280). The flag parser reads
a bare flag as `true`, and `create` only asked whether a required flag was present: a
bare `--ref` went into the manifest as the string "true", a bare `--run-id` as 1, a bare
`--output` wrote a package literally named `true`, and the package re-validated PASS. A
bare `--file` on `validate` tried to open a file called `true`. Every value flag of both
commands now goes through `checkFlagValues`; `--run-id` and `--run-attempt` are also
refused by name when not a whole number of at least 1, where `writeArtifact` had refused
them later with its own wording.

- `collect-remote --out`, `--workflow` and `--ref` given no value are refused (`--<name>
needs a value`, exit 3) before anything is created or dispatched (#270). The flag parser
reads a bare flag as `true`, and these three were not among the checked values: a bare
Expand Down
Loading
Loading