Skip to content

Fix broken build on .NET SDK v10.0.302#1718

Merged
bart-vmware merged 2 commits into
mainfrom
try-new-sdk
Jul 15, 2026
Merged

Fix broken build on .NET SDK v10.0.302#1718
bart-vmware merged 2 commits into
mainfrom
try-new-sdk

Conversation

@bart-vmware

@bart-vmware bart-vmware commented Jul 15, 2026

Copy link
Copy Markdown
Member

Drop the dependencies on Microsoft.IdentityModel.Protocols.OpenIdConnect and Microsoft.IdentityModel.Tokens from libraries and tests. Their explicit versions conflict, while they are already pulled in by Microsoft.AspNetCore.Authentication.JwtBearer.

From what I can tell, these dependencies were introduced in #1311 (Steeltoe 4.0). My assumption is that they were added at the time to be able to use newer APIs or use newer versions that contained fixes we needed.

@github-actions

Copy link
Copy Markdown
Contributor

Summary - All Code Coverage (ubuntu-latest)

Line coverage Branch coverage

Assembly Line coverage Branch coverage
Steeltoe.Bootstrap.AutoConfiguration 97.4% 83.3%
Steeltoe.Common 86.4% 77%
Steeltoe.Common.Certificates 97.2% 80.2%
Steeltoe.Common.Hosting 83.5% 65%
Steeltoe.Common.Http 97.4% 80.9%
Steeltoe.Common.Logging 81.1% 56.2%
Steeltoe.Common.Net 64.5% 66.6%
Steeltoe.Configuration.Abstractions 96.3% 89.4%
Steeltoe.Configuration.CloudFoundry 97.8% 92.7%
Steeltoe.Configuration.ConfigServer 91.6% 86.2%
Steeltoe.Configuration.Encryption 97.6% 87.8%
Steeltoe.Configuration.Kubernetes.ServiceBindings 95.6% 82.6%
Steeltoe.Configuration.Placeholder 93.8% 82.6%
Steeltoe.Configuration.RandomValue 93.2% 83.3%
Steeltoe.Configuration.SpringBoot 98.3% 85%
Steeltoe.Connectors 94.5% 85.6%
Steeltoe.Connectors.EntityFrameworkCore 79.7% 65.3%
Steeltoe.Discovery.Configuration 96.3% 75%
Steeltoe.Discovery.Consul 91.5% 84.4%
Steeltoe.Discovery.Eureka 91.5% 81.3%
Steeltoe.Discovery.HttpClients 89.9% 91.4%
Steeltoe.Logging.Abstractions 99.4% 95.6%
Steeltoe.Logging.DynamicConsole 100% 92.3%
Steeltoe.Logging.DynamicSerilog 99.1% 95.4%
Steeltoe.Management.Abstractions 100% 100%
Steeltoe.Management.Endpoint 96% 87.1%
Steeltoe.Management.Prometheus 95.8% 76.9%
Steeltoe.Management.Tasks 95.2% 80%
Steeltoe.Management.Tracing 100% 75%
Steeltoe.Security.Authentication.JwtBearer 100% 93.7%
Steeltoe.Security.Authentication.OpenIdConnect 87.7% 66.6%
Steeltoe.Security.Authorization.Certificate 95.6% 61.5%
Steeltoe.Security.DataProtection.Redis 100% ****

@sonarqubecloud

Copy link
Copy Markdown

@bart-vmware bart-vmware changed the title Verify build/test against .NET SDK v10.0.302 Fix broken build on .NET SDK v10.0.302 Jul 15, 2026
@bart-vmware
bart-vmware marked this pull request as ready for review July 15, 2026 12:26
@bart-vmware
bart-vmware requested a review from TimHess July 15, 2026 12:27
@TimHess

TimHess commented Jul 15, 2026

Copy link
Copy Markdown
Member

From what I can tell, these dependencies were introduced in #1311 (Steeltoe 4.0). My assumption is that they were added at the time to be able to use newer APIs or use newer versions that contained fixes we needed.

The 10.0.10 release of JwtBearer bumped the OpenIdConnect ref from 8.0.1 to 8.19.2... I don't recall the specific reason for our manual bump, but your assumption seems likely to be accurate

@bart-vmware
bart-vmware merged commit 1f14548 into main Jul 15, 2026
25 checks passed
@bart-vmware
bart-vmware deleted the try-new-sdk branch July 15, 2026 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants