Skip to content

Fixed execution flag on Windows for cms & powershell/pwsh #1423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Nemesis-AS wants to merge 1 commit into
base: master
Choose a base branch
from
+13 −2
Open

Fixed execution flag on Windows for cms & powershell/pwsh #1423

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions src/process.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,20 +3,31 @@ use librespot_metadata::audio::AudioItem;
use librespot_playback::player::PlayerEvent;
use log::info;

use std::{collections::HashMap, process::Stdio};
use std::{collections::HashMap, path::Path, process::Stdio};
use tokio::{
io::{self, AsyncWriteExt},
process::{self, Command},
};

/// Spawns provided command in a subprocess using the provided shell.
fn spawn_program(shell: &str, cmd: &str, env: HashMap<&str, String>) -> Result<Child, Error> {
let exec_flag = match Path::new(shell)
.file_stem()
.and_then(|s| s.to_str())
.map(|s| s.to_ascii_lowercase())
.as_deref()
{
Some("cmd") => "/c",
Some("powershell") | Some("pwsh") => "-Command",
_ => "-c",
};

info!(
"Running {:?} using {:?} with environment variables {:?}",
cmd, shell, env
);
let inner = Command::new(shell)
.arg("-c")
.arg(exec_flag)
.arg(cmd)
.envs(env.iter())
.stdin(Stdio::piped())
Expand Down