Skip to content

fix: restore table height virtualization classname (BED-9057) #3054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dcairnsspecterops wants to merge 3 commits into
base: main
Choose a base branch
from
+33 −26
Open

fix: restore table height virtualization classname (BED-9057) #3054

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5bab32e
restore table height virtualization classname
dcairnsspecterops Jul 25, 2026
2bca121
remove scroll area
dcairnsspecterops Jul 25, 2026
5473bd7
memoize classname
dcairnsspecterops Jul 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
59 changes: 33 additions & 26 deletions packages/javascript/bh-shared-ui/src/components/ExploreTable/ExploreTable.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
//
// SPDX-License-Identifier: Apache-2.0

import { DataTable, ScrollArea } from 'doodle-ui';
import { DataTable } from 'doodle-ui';
import fileDownload from 'js-file-download';
import { json2csv } from 'json-2-csv';
import { ChangeEvent, memo, useCallback, useMemo, useState } from 'react';
Expand Down Expand Up @@ -177,6 +177,15 @@ const ExploreTable = ({
[onChangePinnedColumns]
);

const className = useMemo(
() =>
cn('overflow-auto', {
'h-[calc(50vh-72px)]': !isExpanded,
'h-[calc(100vh-72px)]': !isExpanded,
}),
[isExpanded]
);

return (
<div
data-testid='explore-table-container-wrapper'
Expand All @@ -203,31 +212,29 @@ const ExploreTable = ({
resultsCount={resultsCount}
SearchInputProps={searchInputProps}
/>
<ScrollArea>
<MemoDataTable
TableHeaderProps={tableHeaderProps}
TableHeadProps={tableHeadProps}
TableProps={tableProps}
TableCellProps={tableCellProps}
columnPinning={columnPinning}
setColumnPinning={handleSetColumnPinning}
onRowClick={handleRowClick}
selectedRow={selectedItem || undefined}
data={sortedFilteredRows}
columns={tableColumns as DataTableProps['columns']}
tableOptions={tableOptions}
virtualizationOptions={virtualizationOptions}
columnSizing={columnSizing}
onColumnSizingChange={setColumnSizing}
columnOrder={columnOrder}
onColumnOrderChange={(newOrder) => {
setColumnOrder(newOrder);
}}
growLastColumn
enableResizing
enableDragAndDrop
/>
</ScrollArea>
<MemoDataTable
TableHeaderProps={tableHeaderProps}
TableHeadProps={tableHeadProps}
TableProps={tableProps}
TableCellProps={tableCellProps}
columnPinning={columnPinning}
setColumnPinning={handleSetColumnPinning}
onRowClick={handleRowClick}
selectedRow={selectedItem || undefined}
data={sortedFilteredRows}
columns={tableColumns as DataTableProps['columns']}
tableOptions={tableOptions}
virtualizationOptions={virtualizationOptions}
columnSizing={columnSizing}
onColumnSizingChange={setColumnSizing}
columnOrder={columnOrder}
onColumnOrderChange={(newOrder) => {
setColumnOrder(newOrder);
}}
className={className}
growLastColumn
enableResizing
/>
</div>
</div>
);
Expand Down
Loading