feat: Optimize PG source_kind, relation deletion using indices - BED-8832 - #2942
Open
StephenHinck wants to merge 3 commits into
Open
feat: Optimize PG source_kind, relation deletion using indices - BED-8832#2942StephenHinck wants to merge 3 commits into
StephenHinck wants to merge 3 commits into
Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Organization UI (inherited) Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthrough
ChangesGraph Data Deletion Refactor
Estimated code review effort: 3 (Moderate) | ~20 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
🧹 Nitpick comments (1)
cmd/api/src/daemons/datapipe/delete.go (1)
206-218: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low valueDuplicated drain-and-delete writer loop.
deleteNodesByOperation's writer (Lines 206-218) anddeleteRelationshipsByOperation's writer (Lines 248-260) are identical except for thebatch.DeleteNode/batch.DeleteRelationshipcall. Could extract a small generic helper to remove the duplication.♻️ Proposed shared helper
func drainAndDelete(ctx context.Context, inC <-chan graph.ID, deleteFn func(graph.ID) error) error { for { if nextID, hasNextID := channels.Receive(ctx, inC); hasNextID { if err := deleteFn(nextID); err != nil { return err } } else { return nil } } }nodeOperation.SubmitWriter(func(ctx context.Context, batch graph.Batch, inC <-chan graph.ID) error { - for { - if nextID, hasNextID := channels.Receive(ctx, inC); hasNextID { - if err := batch.DeleteNode(nextID); err != nil { - return err - } - } else { - break - } - } - - return nil + return drainAndDelete(ctx, inC, batch.DeleteNode) })Also applies to: 248-260
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@cmd/api/src/daemons/datapipe/delete.go` around lines 206 - 218, Extract the duplicated drain-and-delete loop from the writers in deleteNodesByOperation and deleteRelationshipsByOperation into a shared drainAndDelete helper accepting the context, input channel, and deletion callback. Have the helper preserve channels.Receive termination and error propagation, then invoke it with batch.DeleteNode or batch.DeleteRelationship respectively.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@cmd/api/src/daemons/datapipe/delete.go`:
- Around line 206-218: Extract the duplicated drain-and-delete loop from the
writers in deleteNodesByOperation and deleteRelationshipsByOperation into a
shared drainAndDelete helper accepting the context, input channel, and deletion
callback. Have the helper preserve channels.Receive termination and error
propagation, then invoke it with batch.DeleteNode or batch.DeleteRelationship
respectively.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Organization UI (inherited)
Review profile: CHILL
Plan: Pro
Run ID: af323718-d2b6-42a1-9cd8-fe1af8ba5ddb
📒 Files selected for processing (1)
cmd/api/src/daemons/datapipe/delete.go
15 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Implements the new DeleteNodesByKinds/DeleteRelationshipsByKinds functions supported optionally on DAWGS drivers to execute rapid deletion of objects by kind. Initially, this is supported on PostgreSQL drivers.
Requires SpecterOps/DAWGS#101
Motivation and Context
Resolves BED-8832
Why is this change required? What problem does it solve?
How Has This Been Tested?
Validated locally and confirmed existing tests continue to pass.
Screenshots (optional):
Tested using large OGGen payloads for validation:
Delete by source_kind:
Before:
After:
Delete by relationship:
Before:
After:
Types of changes
Checklist:
Summary by CodeRabbit