Skip to content

Reject malformed decimal integer strings #3006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
samsamtrum wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Reject malformed decimal integer strings #3006

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions typescript/packages/serializers/src/js/json-to-borsh.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -317,6 +317,9 @@ export class JsonToBorshConverter {
if (integerType.includes("128") || integerType.includes("64")) {
value = BigInt(context.value);
} else {
if (!/^[+-]?\d+$/.test(context.value)) {
throw new Error("Invalid integer");
}
const parsed = Number.parseInt(context.value, 10);
if (isNaN(parsed)) {
throw new Error("NaN");
Expand Down
12 changes: 12 additions & 0 deletions typescript/packages/serializers/tests/js.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,4 +39,16 @@ describe("js", () => {
},
);
});

describe("integer parsing", () => {
it("rejects malformed decimal integer strings", () => {
expect(() => js.serialize({ Number: { U32: "12abc" } }, 0)).toThrow(
"Expected u32",
);
});

it("serializes canonical decimal integer strings", () => {
expect(() => js.serialize({ Number: { U32: "12" } }, 0)).not.toThrow();
});
});
});
Loading