Skip to content

[Hot-Fix] sync with main branch - #60

Merged
bell-person-ii merged 5 commits into
developfrom
main
Feb 23, 2026
Merged

[Hot-Fix] sync with main branch#60
bell-person-ii merged 5 commits into
developfrom
main

Conversation

@bell-person-ii

Copy link
Copy Markdown
Contributor

🎯 목적

V1.0.0을 배포중인 main 브랜치에 적용된 Hot-Fix 들을 develop 브랜치에도 적용합니다.

📋 체크리스트

  • Merge 대상 브랜치가 올바른가?
  • ./gradlew build가 정상적으로 통과하는가?
  • 최종 코드가 에러 없이 잘 동작하는가?
  • 전체 변경사항이 500줄을 넘지 않는가?
  • 관련 테스트 코드를 작성했는가?
  • 기존 테스트가 모두 통과하는가? (./gradlew test)
  • 코드 스타일을 준수하는가? (./gradlew spotlessCheck checkstyleMain)

📌 참고 사항

@bell-person-ii bell-person-ii self-assigned this Feb 23, 2026
@github-actions github-actions Bot added the size/S PR size: S label Feb 23, 2026
@github-actions
github-actions Bot requested a review from junekyu02 February 23, 2026 17:00
@gemini-code-assist

Copy link
Copy Markdown

Summary of Changes

Hello @bell-person-ii, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

이 PR은 V1.0.0 배포에 적용된 Hot-Fix들을 main 브랜치에서 develop 브랜치로 동기화하는 것을 목표로 합니다. 주요 변경사항은 Swagger UI의 접근 제어를 강화하여 프로덕션 환경에서는 비활성화하고, 개발 환경에서만 접근 가능하도록 보안 설정을 업데이트한 것입니다. 이를 통해 환경별 설정 관리를 개선하고 불필요한 노출을 방지합니다.

Highlights

  • Swagger UI 접근 제한: Swagger UI 접근을 비프로덕션 환경으로 제한하여 보안을 강화했습니다.
  • 보안 설정 동적 제어: SecurityConfig에서 Swagger UI 활성화 여부를 동적으로 제어하고, 현재 프로필 및 Swagger 상태를 로깅하도록 개선했습니다.
  • 프로덕션 환경 Swagger 비활성화: application-prod.yaml에서 프로덕션 환경의 Springdoc API 문서 및 Swagger UI를 명시적으로 비활성화했습니다.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • src/main/java/com/example/ssccwebbe/global/config/SwaggerConfig.java
    • @Profile("!prod") 어노테이션을 추가하여 프로덕션 환경에서는 Swagger 설정을 비활성화했습니다.
  • src/main/java/com/example/ssccwebbe/global/security/config/SecurityConfig.java
    • jakarta.annotation.PostConstructlombok.extern.slf4j.Slf4j를 임포트했습니다.
    • 클래스에 @Slf4j 어노테이션을 추가했습니다.
    • swaggerEnabledactiveProfile 값을 주입받도록 필드를 추가했습니다.
    • @PostConstruct 메서드인 checkConfig를 추가하여 활성 프로필과 Swagger UI 활성화 상태를 로깅하도록 했습니다.
    • securityFilterChain 메서드에서 swaggerEnabled 값에 따라 Swagger UI 경로 (/swagger-ui/**, /v3/api-docs/**, /swagger-ui.html)에 대한 접근을 조건부로 허용하도록 변경했습니다.
  • src/main/resources/application-prod.yaml
    • springdoc.api-docs.enabledspringdoc.swagger-ui.enabledfalse로 설정하여 프로덕션 환경에서 Springdoc API 문서와 Swagger UI를 비활성화했습니다.
Activity
  • 현재까지 이 PR에 대한 활동은 없습니다.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@github-actions

Copy link
Copy Markdown

SonarQube Quality Summary (Community)

Quality Gate PASSED

Branch: main
Compared to: default branch

Issues

  • 🐞 Bugs: 0
  • 🔐 Vulnerabilities: 0
  • 📎 Code Smells: 0

Measures

  • Coverage: 0%
  • Duplication: 0%

🔗 Dashboard: https://sonarqube.swthewhite.store/dashboard?id=SSCC-Web-BE&branch=main

Generated automatically by GitHub Actions.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

운영 환경에서 Swagger를 비활성화하고 보안 설정을 강화하는 Hot-Fix 사항들이 잘 반영되었습니다. 다만, 레포지토리 스타일 가이드의 '매직 문자열 상수 추출' 규칙(Rule 30)을 준수하지 않은 부분이 확인되어, URL 경로들을 상수로 관리하도록 개선이 필요합니다. 또한 활성 프로필 확인 방식에 대한 보완 의견을 드립니다.

@bell-person-ii
bell-person-ii merged commit 7065e59 into develop Feb 23, 2026
13 of 14 checks passed
@swthewhite
swthewhite deleted the main branch August 7, 2026 05:23
@swthewhite
swthewhite restored the main branch August 7, 2026 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/S PR size: S

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant