Skip to content

ci: build the overlay so type errors cannot ship #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Snehit70 merged 1 commit into from
Jul 15, 2026
Merged

ci: build the overlay so type errors cannot ship #67

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,22 @@ jobs:
- name: Run tests
run: bun test

# The overlay is a separate npm project with its own tsconfig, so neither
# the root typecheck nor the tests above cover it. Its build is
# `tsc && vite build`, so this catches type errors that would otherwise
# ship a release whose overlay cannot be built at all.
- name: Install overlay dependencies
working-directory: overlay
run: npm install --no-audit --no-fund
env:
# CI only typechecks and bundles the renderer; it never launches
# Electron, so skip the ~100MB binary download.
ELECTRON_SKIP_BINARY_DOWNLOAD: "1"

- name: Build overlay
working-directory: overlay
run: npm run build

@chatgpt-codex-connector chatgpt-codex-connector Bot Jul 15, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Fix the overlay build before adding it to CI

In the current tree this new step will make every PR/main test run fail: overlay/package.json defines build as tsc && vite build, and overlay/src/ipc-client.ts imports ./shared/ipc-types, but there is no overlay/src/shared file and overlay/tsconfig.json only includes src/**/* with no path mapping. I checked the repo-wide references to ipc-types; the only implementation is under the root src/shared, so the newly enforced tsc pass cannot resolve this module until the shared types are copied or the overlay project is wired to the root source correctly.

Useful? React with 👍 / 👎.


- name: Pack package
run: bun x npm pack

Expand Down