-
Notifications
You must be signed in to change notification settings - Fork 326
feat(companion): local due-back reminders for checked-out bookings #2747
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
carlosvirreira
wants to merge
3
commits into
main
Choose a base branch
from
feat/companion-booking-reminders
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| /** | ||
| * Booking reminders — public surface (consumed exports only). | ||
| * | ||
| * Local due-back notifications for bookings checked out from this device: | ||
| * scheduled on checkout, cancelled on check-in/cancel/archive/delete and | ||
| * sign-out, and re-derived from the server on every app foreground so they | ||
| * can never nag about gear that is already back. | ||
| * | ||
| * The pure planner and the reconcile/init internals are deliberately NOT | ||
| * re-exported here — the hook consumes them directly from ./service and | ||
| * ./plan, and an unused public surface is just dead API to maintain. | ||
| * | ||
| * @see {@link file://./plan.ts} pure planner (what fires, when) | ||
| * @see {@link file://./service.ts} runtime (schedule/cancel/reconcile) | ||
| * @see {@link file://./use-booking-reminders.ts} app wiring hook | ||
| */ | ||
| export { | ||
| cancelBookingReminders, | ||
| loadRemindersPreference, | ||
| setRemindersEnabled, | ||
| syncBookingReminders, | ||
| } from "./service"; | ||
| export { useBookingReminders } from "./use-booking-reminders"; | ||
| // NOTE: clearAllBookingReminders is deliberately not re-exported here — its | ||
| // one consumer (auth-context) deep-imports ./service to avoid a require | ||
| // cycle through the org-context-using hook this barrel pulls in. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,44 @@ | ||
| /** | ||
| * Lazy, guarded access to the expo-notifications native module. | ||
| * | ||
| * expo-notifications calls `requireNativeModule(...)` at MODULE TOP LEVEL, | ||
| * so a static `import * as Notifications from "expo-notifications"` crashes | ||
| * at bundle-evaluation time on any binary built before the module was added | ||
| * (e.g. a teammate's older dev client pulling this branch, or an OTA update | ||
| * reaching a pre-notifications build). Call-site try/catch cannot help — the | ||
| * throw happens before any function runs. | ||
| * | ||
| * This wrapper defers the require to first use and memoizes the result, so | ||
| * builds without the native module degrade to a feature-wide no-op instead | ||
| * of a startup crash. Type-only imports of expo-notifications are safe | ||
| * anywhere (erased at compile time); RUNTIME access must go through | ||
| * {@link getNotifications}. | ||
| * | ||
| * @see {@link file://./service.ts} the only intended consumer | ||
| */ | ||
| import type * as ExpoNotifications from "expo-notifications"; | ||
|
|
||
| /** The full expo-notifications API surface, or null when unavailable. */ | ||
| export type NotificationsModule = typeof ExpoNotifications; | ||
|
|
||
| /** `undefined` = not yet attempted; `null` = attempted and unavailable. */ | ||
| let cached: NotificationsModule | null | undefined; | ||
|
|
||
| /** | ||
| * Load expo-notifications on first use. | ||
| * | ||
| * @returns The module, or null when the native side is absent (older build). | ||
| */ | ||
| export function getNotifications(): NotificationsModule | null { | ||
| if (cached !== undefined) return cached; | ||
| try { | ||
| // why: a static import evaluates the package's top-level | ||
| // requireNativeModule() and crashes pre-notifications builds at startup; | ||
| // a guarded require is the only way to degrade gracefully. | ||
| // eslint-disable-next-line @typescript-eslint/no-require-imports | ||
| cached = require("expo-notifications") as NotificationsModule; | ||
| } catch { | ||
| cached = null; | ||
| } | ||
| return cached; | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.