-
Notifications
You must be signed in to change notification settings - Fork 34
[SPH] Add MHD block to Phantom I/O #1889
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
JackNarvaez
wants to merge
7
commits into
Shamrock-code:main
Choose a base branch
from
JackNarvaez:phantom
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 6 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
79a333b
fix: move sink loading outside particle insertion loop to prevent dup…
JackNarvaez 26ea3ab
Read MHD block (B/rho and psi) from dump files
JackNarvaez 34377c1
Write MHD block (B/rho and psi) in dump files
JackNarvaez e0feea1
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 74e2ab8
Merge branch 'main' into phantom
y-lapeyre e8dad9e
Merge branch 'main' into phantom
tdavidcl c957664
Merge branch 'main' into phantom
y-lapeyre File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -143,6 +143,21 @@ namespace shammodels::sph { | |
| /// explicit instanciation for f64_3 | ||
| template AVConfig<f64_3> get_shamrock_avconfig<f64_3>(PhantomDump &phdump); | ||
|
|
||
| template<class Tvec> | ||
| MHDConfig<Tvec> get_shamrock_mhdconfig(PhantomDump &phdump) { | ||
| MHDConfig<Tvec> cfg{}; | ||
|
|
||
| // Defaut values | ||
| cfg.set_ideal_mhd_constrained_hyper_para(0.1, 1); | ||
|
Comment on lines
+150
to
+151
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is there a way to fetch the actual correct values from the dump or are we forced to parse the .in ? NB: If yes maybe we should at some point create an extended version of of the load dump to correctly set the config from the .in |
||
|
|
||
| return cfg; | ||
| } | ||
|
|
||
| /// explicit instanciation for f32_3 | ||
| template MHDConfig<f32_3> get_shamrock_mhdconfig<f32_3>(PhantomDump &phdump); | ||
| /// explicit instanciation for f64_3 | ||
| template MHDConfig<f64_3> get_shamrock_mhdconfig<f64_3>(PhantomDump &phdump); | ||
|
|
||
| template<class Tscal> | ||
| shamunits::UnitSystem<Tscal> get_shamrock_units(PhantomDump &phdump) { | ||
|
|
||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.